You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The MFCC conversion routines could be checked against the torchaudio.transforms equivalent to see whether they match (possibly after tweaking parameters).
If they don't match, that might be interesting, because it could a) hint at errors in either our or their implementation or b) it could mean that we have some interesting alternative algorithm to contribute (mentioned in point 3 of #41).
If they do match, that means we could consider replacing our audio folder altogether with the torchaudio implementation. This might be useful if we would want to switch to other available transforms in the torchaudio package in the future.
It could be that all this is not worth the effort, though. @bhigy what do you think?
The text was updated successfully, but these errors were encountered:
Do you have an idea of how much effort that would require? I am fine with switching to torchaudio if it is rather straightforward. Otherwise I would wait that there is actually a need for this change.
I haven't looked into it, but I would say you should at least reserve half a day to figure out how to reproduce the results of the current MFCC convertors with torchaudio. More than that, it probably would be too much effort anyway.
Waiting until it's needed sounds good in any case.
The MFCC conversion routines could be checked against the torchaudio.transforms equivalent to see whether they match (possibly after tweaking parameters).
If they don't match, that might be interesting, because it could a) hint at errors in either our or their implementation or b) it could mean that we have some interesting alternative algorithm to contribute (mentioned in point 3 of #41).
If they do match, that means we could consider replacing our audio folder altogether with the torchaudio implementation. This might be useful if we would want to switch to other available transforms in the torchaudio package in the future.
It could be that all this is not worth the effort, though. @bhigy what do you think?
The text was updated successfully, but these errors were encountered: