Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to 2.0.4 results in higher memory usage #68

Open
ralfbot opened this issue Mar 11, 2021 · 5 comments
Open

Upgrading to 2.0.4 results in higher memory usage #68

ralfbot opened this issue Mar 11, 2021 · 5 comments

Comments

@ralfbot
Copy link

ralfbot commented Mar 11, 2021

After upgrading from 2.0.2 -> 2.0.4, our application noticed significantly higher memory usage. After reverting back to 2.0.2, memory usage returned back to normal levels. Are there any known issues or relevant changes in 2.0.4 that may have caused this?

Here is a screenshot of the relevant metrics showing the difference between versions:
split_mem

@dmurphy4040
Copy link

Hi Ralph, what’s the total memory and what does a 100% mean in the graph? Does the memory keep increasing (memory leak) or remain steady after it’s “up”? 

The most recent update has an upgrade of Node SDK that enables better impression deduplication. For that we need to use more memory (to cache hashes that enable us to identify the duplicates) so an increase is expected. If nominal, it should not be an issue.

dave

@ralfbot
Copy link
Author

ralfbot commented Mar 12, 2021

The total memory of our instance is 512 MB and 0-100% represents the total percentage of memory used. The memory usage appears to be stable after the upgrade so we don't think there is a memory leak.

The problem is we weren't expecting an overall increase in memory as there was no mention of this on the release. Moving forward it would be helpful to have an official changelog of major changes such as an increased memory footprint. Is this something you would be able to provide?

@dmurphy4040
Copy link

Yes, it should have been noted that there was an increase. The graphic seems to indicate that as a percentage of 512MB it's a pretty large increase. I'm going to check with engineering to see if that's what's expected. You should be able to move to 2.0.4. I do want to follow up on the Evaluator returning different treatments, which definitely should not be happening. We'll do that through the support ticket just created. Thanks

@ralfbot
Copy link
Author

ralfbot commented Mar 18, 2021

Thanks for the update. I see that the 2.0.5 version has been released, is there an official changelog listed for this release anywhere?

@dmurphy4040
Copy link

Hi there, the changes are described here: https://github.com/splitio/split-evaluator/blob/master/CHANGES.txt. This has been updated to include the memory increase in 2.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants