compat: Expose DNonEmpty across more versions of base
#118
Conversation
* Create a single list of quickcheck properties * Test the result of the quickcehck run * Exit with appropriate status code
* Add CPP guards around some instances * Remove some conditional cabal * Use NonEmpty-based fold functions directly * Add tests for fold instance * Disable DNonEmpty test suite on base <4.9.0
414owen
force-pushed
the
os/dnonempty-on-older-base
branch
from
1a29cbd to
e506e24
Compare
|
Thanks for taking the time to do this, but I'm a bit unsure about the motivation or need for this change. Could you be more explicit about what is gained by doing this? What were you unable to do before this change? |
|
Sure, I have a library called I'm a big believer in libraries casting as wide a compatibility net as possible, as it really helps avoid dependency hell. This is especially true of such universal (and useful) libraries as dlist. Multi-except currently supports ghc >=7.0.4, with base being its only dependency. I did this by using my own inline implementation of non-empty dlists. This seems acceptable, because it's such a small amount of code, but at the same time, I don't think the functor instance is optimal. I would prefer to use the implementation from the |
Functions that convert to/from NonEmpty are gone, but everything that you strictly speaking need to use
DNonEmptyis there.