Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Possible) error in Capacity Planning Tutorial #1128

Open
tbaptistal opened this issue Oct 30, 2024 · 6 comments
Open

(Possible) error in Capacity Planning Tutorial #1128

tbaptistal opened this issue Oct 30, 2024 · 6 comments

Comments

@tbaptistal
Copy link

Capacity Planning Tutorial

  • Temporal-structure
    The links between model simple and stochastic structure deterministic :
    There are 3 connectors between these 2 blocks but only 2 now exists.

  • Multi-Year Investment
    The link between temporal blocks and model simple :

This is the updated version:
image

This is the old version:
image

Additional context
https://spine-tools.github.io/SpineOpt.jl/latest/tutorial/figs_capacity_planning/capacity_temporal.png
https://spine-tools.github.io/SpineOpt.jl/latest/tutorial/figs_capacity_planning/multi-year_temporal.png

@datejada
Copy link
Member

@gnawin, would you mind taking a look at this? It is related to the investment tutorials. Thanks!

@gnawin
Copy link
Collaborator

gnawin commented Nov 1, 2024

Hi @tbaptistal,

Thanks for providing feedback. However, I think I did not fully get what you meant. Could you elaborate a bit?

The tutorial starts with the simple system (where there are already 2 connectors between simple and deterministic), and we add the 3rd one for investment. Did you mean that we should only have 2?

@tbaptistal
Copy link
Author

tbaptistal commented Nov 4, 2024

Hi @gnawin,
Thank you for your quick answer! My simple system looks like the tutorial with only 1 connection between simple and deterministic :
image

And then for the investment tutorial I only add 1 connection between simple and deterministic : the default investment connector

Also when I search in the menu to connect these 2 blocks (simple and deterministic), only 2 connectors are valid between the classes stochastic_structure and model :
image

So yes, I feel that in the investment we should only have 2 connections between simple and deterministic

@gnawin
Copy link
Collaborator

gnawin commented Nov 8, 2024

Hi @tbaptistal,
Thanks for the elaboration. Indeed, we need to look into this.

@tarskul it seems something is off in the simple system tutorial, this is what I see in the docs:
image

and this is what I see when I load the simple_system.json from the examples folder:
image

The number of connections between simple and deterministic are different (which caused confusion for @tbaptistal). I suppose we need to update the figure(s) in the docs of the simple system?

@tarskul
Copy link
Collaborator

tarskul commented Nov 12, 2024

If I'm not mistaken, both are possible. The figure in the documentation is actually more recent than the json file. It has been a while but I'm pretty sure that the system worked when I created the figure. I was waiting to update the json file until after the upcoming big structural changes.

@gnawin
Copy link
Collaborator

gnawin commented Nov 18, 2024

Hi @tbaptistal,

So @tarskul (who documented the simple tutorial) confirms that both should be possible. And that there is some discrepancy between what's documented and what's actually provided in the examples jsons. As a result, there also comes some inconsistency between the different tutorials.

Thank you for pointing out this, and we will make sure they are consistent when we review the tutorials again after the upcoming structural changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants