Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover more combinations of functionality in the tests #1084

Open
DillonJ opened this issue Sep 3, 2024 · 0 comments
Open

Cover more combinations of functionality in the tests #1084

DillonJ opened this issue Sep 3, 2024 · 0 comments
Labels
Type: improvement Improve something that already exists Zone: testing & validation Check code & outputs match what's expected

Comments

@DillonJ
Copy link
Collaborator

DillonJ commented Sep 3, 2024

Is your feature request related to a problem? Please describe.
Tests cover only a limited combination of SpineOpt functionalities

Describe the solution you'd like
Cover more combinations of functionalities

Describe alternatives you've considered
N/A

In some recent commits to SpineOpt, there were issues with fix_ratio constraints because the tests did not test a sufficient range of possible combinations of fix_ratio parameters. A possible solution is to increase the complexity of the example systems. Specifically, there should be units which have multiple inputs and outputs and have fix_ratio parameters defined on multiple combinations of flows.

Generally speaking, we could increase the complexity of the example systems.

@DillonJ DillonJ added the Zone: testing & validation Check code & outputs match what's expected label Sep 3, 2024
@clizbe clizbe added the Type: improvement Improve something that already exists label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: improvement Improve something that already exists Zone: testing & validation Check code & outputs match what's expected
Projects
None yet
Development

No branches or pull requests

2 participants