Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importers and Exporters require GAMS 42 or newer #2995

Open
soininen opened this issue Oct 31, 2024 · 4 comments
Open

Importers and Exporters require GAMS 42 or newer #2995

soininen opened this issue Oct 31, 2024 · 4 comments
Assignees
Labels
enhancement Enhancement of existing feature
Milestone

Comments

@soininen
Copy link
Contributor

We switched from dgxcc to gamsapi some time ago. I finally figured out the oldest GAMS version that supports gamsapi and it is 42. We should upgrade the note in CHANGELOG.md (for version 0.8.4). If possible, we should also check and warn user if their GAMS installation is too old in "proper places" (find_gams_directory()?).

@soininen soininen added the enhancement Enhancement of existing feature label Oct 31, 2024
@jkiviluo
Copy link
Member

jkiviluo commented Nov 1, 2024

gamsapi may also be used without using gams itself or the gdx files that are created with gamsapi are used with older gams (should be compatible). So, I think it's not necessary to check for the GAMS installation version - we wouldn't know the users intent.

@soininen
Copy link
Contributor Author

soininen commented Nov 1, 2024

The old dgxcc package did require a GAMS installation so I thought it would be the same with the compatibility layer of gamsapi. Looks like I have been wrong all along. This simplifies things a lot as it allow us to drop the requirement of GAMS installation (and the knowledge of GAMS dir) from Exporter and Importer.

@soininen soininen self-assigned this Nov 1, 2024
@soininen
Copy link
Contributor Author

soininen commented Nov 4, 2024

I misunderstood the situation. The legacy functionality in gamsapi that we use in Importer/Exporter does require a GAMS installation. This should not force users to specific GAMS version in their Tools, though. I guess the solution would be to allow users to set a different GAMS for Importer/Exporter in settings.

@soininen soininen changed the title We require GAMS 42 or newer Importers and Exporters require GAMS 42 or newer Nov 4, 2024
@jkiviluo
Copy link
Member

jkiviluo commented Nov 5, 2024

Settings should have two boxes:

  • GAMS executable for importer/exporters - also available for GAMS tools
  • Additional GAMS executables available for GAMS tools [list]

Then in tool spec one can choose which to use. The first one can also be checked for version (at least GAMS 42).

@jkiviluo jkiviluo added this to the next release milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing feature
Projects
None yet
Development

No branches or pull requests

2 participants