Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated SDKs, caching, more apps and video #2

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Updated SDKs, caching, more apps and video #2

wants to merge 16 commits into from

Conversation

alexportnoy
Copy link

Hi!
I use your plugin in my project and have some additional things that might be useful in your main branch.
Changes I've made:

  1. replaced outdated SDKs with latest versions
  2. added some methods:
  • cacheInterstitial (iOS/Android)
  • cacheMoreGames/showMoreGames (iOS)
  • cacheRewardedVideo/showRewardedVideo (iOS)
  1. refactored dealing with JS-callbacks

Please, take a look if you're interested.

@jbeerdev
Copy link
Contributor

jbeerdev commented Apr 2, 2015

Great. I will take a look at it.

@jbeerdev
Copy link
Contributor

jbeerdev commented Apr 7, 2015

Hi Alexportnoy, I can't merge the PR, I have lost writing rights from this repo. :S

@alexportnoy
Copy link
Author

Wouldn't you mind then if I submit this to cordova's registry under new pluginId, mentioning that it's fork from your original repo ?

@jbeerdev
Copy link
Contributor

jbeerdev commented Apr 7, 2015

Totally fine by me :)

2015-04-07 9:15 GMT+02:00 Alexander Portnoy [email protected]:

Wouldn't you mind then if I submit this to cordova's registry under new
pluginId, mentioning that it's fork from your original repo ?


Reply to this email directly or view it on GitHub
#2 (comment)
.

@alexportnoy
Copy link
Author

Great, thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants