Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Option to specify the Travis platform #145

Open
MrinalJain17 opened this issue Oct 9, 2018 · 3 comments · May be fixed by #147
Open

[Bug] Option to specify the Travis platform #145

MrinalJain17 opened this issue Oct 9, 2018 · 3 comments · May be fixed by #147
Milestone

Comments

@MrinalJain17
Copy link

Traditionally, Travis-ci provides 2 platforms: travis-ci.com - for private/paid repos and travis-ci.org - for free repos. But according to this announcement, all projects from .org will move to .com eventually.

The problem is that when setting travis_button=True, the badge displays the build status of the repo from travis-ci.org, which might not be the case for all the users. For someone having the repo activated on travis-ci.com, the badge will not show the proper build status.

For instance, in my case, the build was passing, but the badge showed unknown - since my repo is activated on travis-ci.com and not on travis-ci.org.

@JurajMa
Copy link

JurajMa commented Nov 13, 2018

Same problem here.

@webknjaz
Copy link

webknjaz commented Dec 17, 2018

Ah.. was just about to create the same issue.

Occurrences in two docs sites I maintain (there's much more):

And this misleading button was there since May.. This needs to be fixed ASAP. I'm going to submit a PR.

@bitprophet ^

@webknjaz
Copy link

webknjaz commented Dec 17, 2018

Done: #147

UPD: If somebody is looking to monkey-patch
it in their project while this isn't
merged — just apply this 👇

                sanitizers/octomachinery@e5756d9

webknjaz added a commit to webknjaz/alabaster that referenced this issue Dec 17, 2018
webknjaz added a commit to webknjaz/alabaster that referenced this issue Dec 17, 2018
webknjaz added a commit to webknjaz/alabaster that referenced this issue Dec 17, 2018
webknjaz added a commit to webknjaz/alabaster that referenced this issue Dec 17, 2018
@bitprophet bitprophet added this to the 0.7.13 milestone Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants