Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace bespoke save-queue dialog with tvxwidgets #69

Open
xxxserxxx opened this issue Oct 14, 2024 · 2 comments
Open

Replace bespoke save-queue dialog with tvxwidgets #69

xxxserxxx opened this issue Oct 14, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@xxxserxxx
Copy link
Collaborator

There are a couple of places where it might be better to use tvxwidgets instead of the current bespoke stmps widgets. In particular, the dialog added as part of the save-queue-as-playlist feature is a lot of tedious code to correctly handle widget selection in the dialog. tvxwidgets also has some other "fancy" widgets, like proper progress bars, that stmps might have use for.

This ticket is specifically for integrating tvxwidgets to replace the save dialog, and can be closed when that's done. Other refactorings can be other tickets (lest this be a perpetually open ticket).

@spezifisch spezifisch added this to the v1.1.0 milestone Oct 14, 2024
@spezifisch spezifisch added the enhancement New feature or request label Oct 14, 2024
@xxxserxxx
Copy link
Collaborator Author

A second place is the spinner; tvxwidgets provides a spinner that's nearly identical to the one being used during the playlist load.

@xxxserxxx
Copy link
Collaborator Author

I looked into this in branch tvxwidgets and came to the conclusion that it was a dead-end. I don't remember why anymore; I think it was because tvxwidgets adds a dependency without dramatically simplifying the code.

I'm not looking into this anymore -- close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants