Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Display song lyrics for the playing song #49

Open
xxxserxxx opened this issue Sep 26, 2024 · 1 comment
Open

[Feature] Display song lyrics for the playing song #49

xxxserxxx opened this issue Sep 26, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@xxxserxxx
Copy link
Collaborator

Subsonic provides an API for fetching lyrics for a song. This feature would show those lyrics for the playing song.

While this seems straightforward, this is deceptive as there are several considerations:

  • Lyrics can be either simple line-by-line text, but they could also be .lrc formatted data. LRC includes timestamps in the lyrics for synchronization
  • Where would these lyrics be displayed? If LRC data exists, a number of options present themselves, including displaying each line, in sync with the song, at the bottom (or top, possibly just under the status bar) of the window.
  • If the lyrics contain no LRC timings, or if synchronized display is undesirable, lyrics could be displayed simply, under the metadata in the queue song info column.

LRC itself isn't too challenging, and wouldn't require a library for parsing; nor do I think there's much complexity in displaying the lyrics, either way. Regardless, this is a feature that would bear discussion and consensus before implementation.

@spezifisch spezifisch added the enhancement New feature or request label Oct 13, 2024
@xxxserxxx xxxserxxx added this to the v1.1.0 milestone Oct 15, 2024
@xxxserxxx xxxserxxx self-assigned this Oct 15, 2024
@xxxserxxx xxxserxxx removed this from the v1.1.0 milestone Oct 16, 2024
@xxxserxxx
Copy link
Collaborator Author

xxxserxxx commented Oct 16, 2024

Neither Navidrome nor gonic support fetching lrc lyrics through the API, so I'm shelving this.

Closing to clear it from the issues; we can re-open it if the situation changes.

@xxxserxxx xxxserxxx closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2024
@xxxserxxx xxxserxxx reopened this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants