From 04561ee34045c24fd22de51d9e44014ecf479457 Mon Sep 17 00:00:00 2001
From: Carolina Delwing Rosa <carolina.delwing@spectrocloud.com>
Date: Tue, 24 Dec 2024 11:11:30 -0300
Subject: [PATCH] docs: improve log message, add emojis

---
 .github/workflows/cluster_scanner.yaml                    | 3 +--
 scripts/cluster-scanner/internal/search_old_clusters.go   | 2 +-
 .../cluster-scanner/internal/search_old_clusters_test.go  | 8 ++++----
 scripts/cluster-scanner/main.go                           | 2 +-
 4 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/cluster_scanner.yaml b/.github/workflows/cluster_scanner.yaml
index bbc1e97..5292987 100644
--- a/.github/workflows/cluster_scanner.yaml
+++ b/.github/workflows/cluster_scanner.yaml
@@ -43,7 +43,7 @@ jobs:
       - name: Get Clusters with More Than 24 Hours and Format Output
         working-directory: scripts/cluster-scanner
         run: |
-          if grep -q "The following clusters have been running for more than 24 hours" result.log; then
+          if grep -q "The following clusters have been running" result.log; then
             echo "CLUSTERS_FOUND=true" >> $GITHUB_ENV
             {
               echo 'LOG_MESSAGE<<EOF'
@@ -58,7 +58,6 @@ jobs:
         env:
           SLACK_WEBHOOK: ${{ secrets.SLACK_PRIVATE_TEAM_WEBHOOK }}
           SLACK_USERNAME: "spectromate"
-          SLACK_ICON_EMOJI: ":clock1:"
           SLACK_COLOR: "good"
           SLACKIFY_MARKDOWN: true
           ENABLE_ESCAPES: true
diff --git a/scripts/cluster-scanner/internal/search_old_clusters.go b/scripts/cluster-scanner/internal/search_old_clusters.go
index f648f5b..15a7523 100644
--- a/scripts/cluster-scanner/internal/search_old_clusters.go
+++ b/scripts/cluster-scanner/internal/search_old_clusters.go
@@ -24,7 +24,7 @@ func SearchOldClusters(clusters []*models.V1SpectroClusterSummary) ([]string, er
 			if err != nil {
 				return nil, err
 			}
-			message := fmt.Sprintf("-'%s' cluster (%s) - %s", cluster.Metadata.Name, cluster.SpecSummary.CloudConfig.CloudType, *age)
+			message := fmt.Sprintf("❗️%s cluster '%s' - %s ⏳", cluster.SpecSummary.CloudConfig.CloudType, cluster.Metadata.Name, *age)
 			messageArray = append(messageArray, message)
 		}
 	}
diff --git a/scripts/cluster-scanner/internal/search_old_clusters_test.go b/scripts/cluster-scanner/internal/search_old_clusters_test.go
index 5871fff..43f0c56 100644
--- a/scripts/cluster-scanner/internal/search_old_clusters_test.go
+++ b/scripts/cluster-scanner/internal/search_old_clusters_test.go
@@ -43,7 +43,7 @@ func TestSearchOldClusters (t *testing.T) {
 				createSummary("-30h", "test-cluster", "aws"),
 			},
 			output: []string{
-				"-'test-cluster' cluster (aws) - 1 days 6 hours",
+				"❗️aws cluster 'test-cluster' - 1 days 6 hours ⏳",
 			},
 		},
 		"two clusters older than 24h":{
@@ -52,8 +52,8 @@ func TestSearchOldClusters (t *testing.T) {
 				createSummary("-50h", "test-cluster-azure", "azure"),
 			},
 			output: []string{
-				"-'test-cluster' cluster (aws) - 1 days 6 hours",
-				"-'test-cluster-azure' cluster (azure) - 2 days 2 hours",
+				"❗️aws cluster 'test-cluster' - 1 days 6 hours ⏳",
+				"❗️azure cluster 'test-cluster-azure' - 2 days 2 hours ⏳",
 			},
 		},
 		"one cluster with 24h":{
@@ -61,7 +61,7 @@ func TestSearchOldClusters (t *testing.T) {
 				createSummary("-24h", "test-cluster", "aws"),
 			},
 			output: []string{
-				"-'test-cluster' cluster (aws) - 1 days ",
+				"❗️aws cluster 'test-cluster' - 1 days  ⏳",
 			},
 		},
 		"one cluster with less than 24h":{
diff --git a/scripts/cluster-scanner/main.go b/scripts/cluster-scanner/main.go
index 1db3978..98254c9 100644
--- a/scripts/cluster-scanner/main.go
+++ b/scripts/cluster-scanner/main.go
@@ -60,7 +60,7 @@ func main() {
 		os.Exit(2)
 	}
 	if len(messageArray) != 0 {
-		logger.Info("The following clusters have been running for more than 24 hours. Please delete them if they are no longer needed.")
+		logger.Info("The following clusters have been running for over 24 hours. Please delete them if they're no longer needed:")
 		for _, message := range messageArray {
 			logger.Info(message)
 		}