PEM-6153-fixed the fragment url to follow the actual content #4697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nage1234
requested review from
karl-cardenas-coding,
addetz,
caroldelwing and
codrin-iftimie
✅ Deploy Preview for docs-spectrocloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nageshsairam1610
approved these changes
Nov 18, 2024
nageshsairam1610
approved these changes
Nov 28, 2024
karl-cardenas-coding
added
backport-version-4-0
karl-cardenas-coding
changed the title
karl-cardenas-coding
changed the title
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
…4697) * PEM-6153-fixed the fragment url to follow the actual content * ci: auto-formatting prettier issues * changed the click as scrollIntoView * reverting back to click * fixed the fragment url for main Readme as well * ci: auto-formatting prettier issues * cleaned up * ci: auto-formatting prettier issues * addressed the review comments * added fragment link support for h1 as well --------- Co-authored-by: nage1234 <[email protected]> Co-authored-by: Karl Cardenas <[email protected]> (cherry picked from commit db85b2d)
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
…4697) * PEM-6153-fixed the fragment url to follow the actual content * ci: auto-formatting prettier issues * changed the click as scrollIntoView * reverting back to click * fixed the fragment url for main Readme as well * ci: auto-formatting prettier issues * cleaned up * ci: auto-formatting prettier issues * addressed the review comments * added fragment link support for h1 as well --------- Co-authored-by: nage1234 <[email protected]> Co-authored-by: Karl Cardenas <[email protected]> (cherry picked from commit db85b2d)
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
…4697) * PEM-6153-fixed the fragment url to follow the actual content * ci: auto-formatting prettier issues * changed the click as scrollIntoView * reverting back to click * fixed the fragment url for main Readme as well * ci: auto-formatting prettier issues * cleaned up * ci: auto-formatting prettier issues * addressed the review comments * added fragment link support for h1 as well --------- Co-authored-by: nage1234 <[email protected]> Co-authored-by: Karl Cardenas <[email protected]> (cherry picked from commit db85b2d)
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
…4697) * PEM-6153-fixed the fragment url to follow the actual content * ci: auto-formatting prettier issues * changed the click as scrollIntoView * reverting back to click * fixed the fragment url for main Readme as well * ci: auto-formatting prettier issues * cleaned up * ci: auto-formatting prettier issues * addressed the review comments * added fragment link support for h1 as well --------- Co-authored-by: nage1234 <[email protected]> Co-authored-by: Karl Cardenas <[email protected]> (cherry picked from commit db85b2d)
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
…4697) * PEM-6153-fixed the fragment url to follow the actual content * ci: auto-formatting prettier issues * changed the click as scrollIntoView * reverting back to click * fixed the fragment url for main Readme as well * ci: auto-formatting prettier issues * cleaned up * ci: auto-formatting prettier issues * addressed the review comments * added fragment link support for h1 as well --------- Co-authored-by: nage1234 <[email protected]> Co-authored-by: Karl Cardenas <[email protected]> (cherry picked from commit db85b2d)
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
…4697) * PEM-6153-fixed the fragment url to follow the actual content * ci: auto-formatting prettier issues * changed the click as scrollIntoView * reverting back to click * fixed the fragment url for main Readme as well * ci: auto-formatting prettier issues * cleaned up * ci: auto-formatting prettier issues * addressed the review comments * added fragment link support for h1 as well --------- Co-authored-by: nage1234 <[email protected]> Co-authored-by: Karl Cardenas <[email protected]> (cherry picked from commit db85b2d)
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
…4697) * PEM-6153-fixed the fragment url to follow the actual content * ci: auto-formatting prettier issues * changed the click as scrollIntoView * reverting back to click * fixed the fragment url for main Readme as well * ci: auto-formatting prettier issues * cleaned up * ci: auto-formatting prettier issues * addressed the review comments * added fragment link support for h1 as well --------- Co-authored-by: nage1234 <[email protected]> Co-authored-by: Karl Cardenas <[email protected]> (cherry picked from commit db85b2d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
vault-token-factory-spectrocloud bot
added a commit
that referenced
this pull request
Dec 4, 2024
…4697) (#4862) * PEM-6153-fixed the fragment url to follow the actual content * ci: auto-formatting prettier issues * changed the click as scrollIntoView * reverting back to click * fixed the fragment url for main Readme as well * ci: auto-formatting prettier issues * cleaned up * ci: auto-formatting prettier issues * addressed the review comments * added fragment link support for h1 as well --------- Co-authored-by: nage1234 <[email protected]> Co-authored-by: Karl Cardenas <[email protected]> (cherry picked from commit db85b2d) Co-authored-by: Nageswari Raghunathan <[email protected]>
vault-token-factory-spectrocloud bot
added a commit
that referenced
this pull request
Dec 4, 2024
…4697) (#4863) * PEM-6153-fixed the fragment url to follow the actual content * ci: auto-formatting prettier issues * changed the click as scrollIntoView * reverting back to click * fixed the fragment url for main Readme as well * ci: auto-formatting prettier issues * cleaned up * ci: auto-formatting prettier issues * addressed the review comments * added fragment link support for h1 as well --------- Co-authored-by: nage1234 <[email protected]> Co-authored-by: Karl Cardenas <[email protected]> (cherry picked from commit db85b2d) Co-authored-by: Nageswari Raghunathan <[email protected]>
vault-token-factory-spectrocloud bot
added a commit
that referenced
this pull request
Dec 4, 2024
…4697) (#4864) * PEM-6153-fixed the fragment url to follow the actual content * ci: auto-formatting prettier issues * changed the click as scrollIntoView * reverting back to click * fixed the fragment url for main Readme as well * ci: auto-formatting prettier issues * cleaned up * ci: auto-formatting prettier issues * addressed the review comments * added fragment link support for h1 as well --------- Co-authored-by: nage1234 <[email protected]> Co-authored-by: Karl Cardenas <[email protected]> (cherry picked from commit db85b2d) Co-authored-by: Nageswari Raghunathan <[email protected]>
vault-token-factory-spectrocloud bot
added a commit
that referenced
this pull request
Dec 4, 2024
…4697) (#4866) * PEM-6153-fixed the fragment url to follow the actual content * ci: auto-formatting prettier issues * changed the click as scrollIntoView * reverting back to click * fixed the fragment url for main Readme as well * ci: auto-formatting prettier issues * cleaned up * ci: auto-formatting prettier issues * addressed the review comments * added fragment link support for h1 as well --------- Co-authored-by: nage1234 <[email protected]> Co-authored-by: Karl Cardenas <[email protected]> (cherry picked from commit db85b2d) Co-authored-by: Nageswari Raghunathan <[email protected]>
vault-token-factory-spectrocloud bot
added a commit
that referenced
this pull request
Dec 4, 2024
…4697) (#4865) * PEM-6153-fixed the fragment url to follow the actual content * ci: auto-formatting prettier issues * changed the click as scrollIntoView * reverting back to click * fixed the fragment url for main Readme as well * ci: auto-formatting prettier issues * cleaned up * ci: auto-formatting prettier issues * addressed the review comments * added fragment link support for h1 as well --------- Co-authored-by: nage1234 <[email protected]> Co-authored-by: Karl Cardenas <[email protected]> (cherry picked from commit db85b2d) Co-authored-by: Nageswari Raghunathan <[email protected]>
vault-token-factory-spectrocloud bot
added a commit
that referenced
this pull request
Dec 4, 2024
…4697) (#4867) * PEM-6153-fixed the fragment url to follow the actual content * ci: auto-formatting prettier issues * changed the click as scrollIntoView * reverting back to click * fixed the fragment url for main Readme as well * ci: auto-formatting prettier issues * cleaned up * ci: auto-formatting prettier issues * addressed the review comments * added fragment link support for h1 as well --------- Co-authored-by: nage1234 <[email protected]> Co-authored-by: Karl Cardenas <[email protected]> (cherry picked from commit db85b2d) Co-authored-by: Nageswari Raghunathan <[email protected]>
vault-token-factory-spectrocloud bot
added a commit
that referenced
this pull request
Dec 4, 2024
…4697) (#4868) * PEM-6153-fixed the fragment url to follow the actual content * ci: auto-formatting prettier issues * changed the click as scrollIntoView * reverting back to click * fixed the fragment url for main Readme as well * ci: auto-formatting prettier issues * cleaned up * ci: auto-formatting prettier issues * addressed the review comments * added fragment link support for h1 as well --------- Co-authored-by: nage1234 <[email protected]> Co-authored-by: Karl Cardenas <[email protected]> (cherry picked from commit db85b2d) Co-authored-by: Nageswari Raghunathan <[email protected]>
|
🎉 This PR is included in version 4.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🤖 Starting the visual tests. This will take approximately an hour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Change
The change made as part of this PR is, when we load the packs doc page with fragment identifier (followed by "#"), it takes to the exact fragment in the "Additional Details"
Changed Pages
No access to netify, but, it doesnt impact on the design , in the packs page, go to pack detail page of any packs.
or directly hit the URL,
Preview URL
Jira Tickets
https://spectrocloud.atlassian.net/browse/PEM-6153
Backports
Can this PR be backported?