-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fixing packs deprecated logic #1732
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-spectrocloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
karl-cardenas-coding
requested review from
lennessyy,
caroldelwing and
ritawatson
November 1, 2023 18:30
karl-cardenas-coding
added
bug
Something isn't working
backport-version-4-0
Backport change to version 4.0
auto-backport
Enable backport
backport-version-3-4
Backport change to version 3.4
backport-version-4-1
Backport change to version 4.1
labels
Nov 1, 2023
lennessyy
approved these changes
Nov 1, 2023
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
* chore: fixing packs deprecated logic * chore: fixed logic * chore: minor field fix * chore: added prod status in test * chore: removed debugger statement (cherry picked from commit 97b3227)
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
* chore: fixing packs deprecated logic * chore: fixed logic * chore: minor field fix * chore: added prod status in test * chore: removed debugger statement (cherry picked from commit 97b3227)
This was referenced Nov 1, 2023
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
* chore: fixing packs deprecated logic * chore: fixed logic * chore: minor field fix * chore: added prod status in test * chore: removed debugger statement (cherry picked from commit 97b3227)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
karl-cardenas-coding
added a commit
that referenced
this pull request
Nov 1, 2023
* chore: fixing packs deprecated logic * chore: fixed logic * chore: minor field fix * chore: added prod status in test * chore: removed debugger statement (cherry picked from commit 97b3227) Co-authored-by: Karl Cardenas <[email protected]>
karl-cardenas-coding
added a commit
that referenced
this pull request
Nov 1, 2023
* chore: fixing packs deprecated logic * chore: fixed logic * chore: minor field fix * chore: added prod status in test * chore: removed debugger statement (cherry picked from commit 97b3227) Co-authored-by: Karl Cardenas <[email protected]>
karl-cardenas-coding
added a commit
that referenced
this pull request
Nov 1, 2023
* chore: fixing packs deprecated logic * chore: fixed logic * chore: minor field fix * chore: added prod status in test * chore: removed debugger statement (cherry picked from commit 97b3227) Co-authored-by: Karl Cardenas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Enable backport
backport-version-3-4
Backport change to version 3.4
backport-version-4-0
Backport change to version 4.0
backport-version-4-1
Backport change to version 4.1
bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Change
This PR fixes an issue that resulted from the new Packs Reporter release. The field is now also using the
prodStatus
field instead of the previousstatus
field, which represents the internal git status.Review Changes
💻 Preview URL