Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixing packs deprecated logic #1732

Merged
merged 5 commits into from
Nov 1, 2023
Merged

Conversation

karl-cardenas-coding
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding commented Nov 1, 2023

Describe the Change

This PR fixes an issue that resulted from the new Packs Reporter release. The field is now also using the prodStatus field instead of the previous status field, which represents the internal git status.

Review Changes

💻 Preview URL

Copy link

netlify bot commented Nov 1, 2023

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/65429bfa84e9a00bd930f4cf
😎 Deploy Preview https://deploy-preview-1732--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@karl-cardenas-coding karl-cardenas-coding marked this pull request as ready for review November 1, 2023 18:30
@karl-cardenas-coding karl-cardenas-coding requested a review from a team as a code owner November 1, 2023 18:30
@karl-cardenas-coding karl-cardenas-coding added bug Something isn't working backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-1 Backport change to version 4.1 labels Nov 1, 2023
@karl-cardenas-coding karl-cardenas-coding enabled auto-merge (squash) November 1, 2023 18:55
@karl-cardenas-coding karl-cardenas-coding merged commit 97b3227 into master Nov 1, 2023
9 checks passed
@karl-cardenas-coding karl-cardenas-coding deleted the deprecated-fix branch November 1, 2023 19:01
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Nov 1, 2023
* chore: fixing packs deprecated logic

* chore: fixed logic

* chore: minor field fix

* chore: added prod status in test

* chore: removed debugger statement

(cherry picked from commit 97b3227)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Nov 1, 2023
* chore: fixing packs deprecated logic

* chore: fixed logic

* chore: minor field fix

* chore: added prod status in test

* chore: removed debugger statement

(cherry picked from commit 97b3227)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Nov 1, 2023
* chore: fixing packs deprecated logic

* chore: fixed logic

* chore: minor field fix

* chore: added prod status in test

* chore: removed debugger statement

(cherry picked from commit 97b3227)
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
version-4-0
version-3-4
version-4-1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

karl-cardenas-coding added a commit that referenced this pull request Nov 1, 2023
* chore: fixing packs deprecated logic

* chore: fixed logic

* chore: minor field fix

* chore: added prod status in test

* chore: removed debugger statement

(cherry picked from commit 97b3227)

Co-authored-by: Karl Cardenas <[email protected]>
karl-cardenas-coding added a commit that referenced this pull request Nov 1, 2023
* chore: fixing packs deprecated logic

* chore: fixed logic

* chore: minor field fix

* chore: added prod status in test

* chore: removed debugger statement

(cherry picked from commit 97b3227)

Co-authored-by: Karl Cardenas <[email protected]>
karl-cardenas-coding added a commit that referenced this pull request Nov 1, 2023
* chore: fixing packs deprecated logic

* chore: fixed logic

* chore: minor field fix

* chore: added prod status in test

* chore: removed debugger statement

(cherry picked from commit 97b3227)

Co-authored-by: Karl Cardenas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants