Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add cloud types column to deprecated packs list (DOC-903) #1731

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

lennessyy
Copy link
Contributor

@lennessyy lennessyy commented Oct 31, 2023

Describe the Change

This PR adds the cloud types column to the Deprecated Packs table:

  • Adds a function that handles string transformation for cloud types.
  • Adds a test that ensures cloud provider names are displayed correctly

Review Changes

💻 Deprecated packs table

🎫 DOC-903

Copy link

netlify bot commented Oct 31, 2023

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit a669c66
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/6541803e2a0b7900084b5018
😎 Deploy Preview https://deploy-preview-1731--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lennessyy lennessyy changed the title feat: add cloud types column to deprecated packs list feat: add cloud types column to deprecated packs list (DOC-903) Oct 31, 2023
@lennessyy lennessyy marked this pull request as ready for review October 31, 2023 21:36
@lennessyy lennessyy requested a review from a team as a code owner October 31, 2023 21:36
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change @lennessyy . I have one suggestion below we need to address.

Lastly, when you squash the commit, make sure the commit prefix feat is not used. We only want to cut a new tag when we release a new version of Palette. Use chore

src/components/PacksTable/PacksTable.tsx Outdated Show resolved Hide resolved
@lennessyy lennessyy changed the title feat: add cloud types column to deprecated packs list (DOC-903) chore: add cloud types column to deprecated packs list (DOC-903) Oct 31, 2023
@lennessyy lennessyy enabled auto-merge (squash) October 31, 2023 22:32
@lennessyy lennessyy disabled auto-merge October 31, 2023 22:32
@lennessyy lennessyy merged commit 30a9b9a into master Oct 31, 2023
9 checks passed
@lennessyy lennessyy deleted the infra-provider-display branch October 31, 2023 23:07
lennessyy added a commit that referenced this pull request Nov 1, 2023
* chore: add cloud types column to deprecated packs list

* Update src/components/PacksTable/PacksTable.tsx

Co-authored-by: Karl Cardenas <[email protected]>

---------

Co-authored-by: Lenny Chen <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
lennessyy added a commit that referenced this pull request Nov 1, 2023
* chore: add cloud types column to deprecated packs list

* Update src/components/PacksTable/PacksTable.tsx

Co-authored-by: Karl Cardenas <[email protected]>

---------

Co-authored-by: Lenny Chen <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
lennessyy added a commit that referenced this pull request Nov 1, 2023
…) (#1744)

* chore: add cloud types column to deprecated packs list

* Update src/components/PacksTable/PacksTable.tsx



---------

Co-authored-by: Lenny Chen <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
lennessyy added a commit that referenced this pull request Jan 11, 2024
* chore: add cloud types column to deprecated packs list

* Update src/components/PacksTable/PacksTable.tsx

Co-authored-by: Karl Cardenas <[email protected]>

---------

Co-authored-by: Lenny Chen <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
lennessyy added a commit that referenced this pull request Jan 11, 2024
* chore: add cloud types column to deprecated packs list (DOC-903) (#1731)

* chore: add cloud types column to deprecated packs list

* Update src/components/PacksTable/PacksTable.tsx

Co-authored-by: Karl Cardenas <[email protected]>

---------

Co-authored-by: Lenny Chen <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>

* fix video elements

---------

Co-authored-by: Lenny Chen <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants