Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If second set of coordinates fields are present, they are required for Geo Coords #64

Open
grantfitzsimmons opened this issue Apr 15, 2022 · 1 comment

Comments

@grantfitzsimmons
Copy link
Member

If second set of coordinates fields are present, they are required for the record to count as Geo Coords referenceable.

Screenshots:
How it should behave:
image

If a record has empty Lat2 and/or Long2 field(s) in the mapping, the first set of coordinates do not count as Geo Coords alone.

image

Reported By: Shell Museum
@benanhalt

@benanhalt
Copy link
Contributor

The relevant function is at

getGeoCoordRequirementFilter: function(forJSON) {
var result = '';
var gFlds = this.getGeoCoordFlds();
for (var f = 0; f < gFlds.length; f++) {
if (f > 0) {
result += forJSON ? ' AND ' : '+AND+';
}
//result += gFlds[f] + ':[\\"\\" TO ^]';
result += gFlds[f] + ':[-180 TO 180]';
}
return result;
},

I think it could be modified to only check the first set of coords without breaking anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants