Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds compatibility with the latest MJML v5.0 Alpha. The
mjml2html
function now returns aPromise
instead of running synchronously. Compatibility is simple since we can just use a top-levelawait
here, which will work with previous versions sinceawait
will just wrap a value in a Promise if the value is not already a Promise.The reason for patching this and adding alpha version compatibility is due to MJML v4.0 currently relying on a package that has a high severity security vulnerability that isn't going to be patched:
mjmlio/mjml#2589 (comment)