Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XPath performance improvements #3403

Open
flavorjones opened this issue Jan 3, 2025 · 1 comment
Open

XPath performance improvements #3403

flavorjones opened this issue Jan 3, 2025 · 1 comment
Milestone

Comments

@flavorjones
Copy link
Member

From comments at #3378:

  • Enable the XPath cache. Nick says "The cache speeds up allocation of XPath objects. In general, it's a good idea to enable it."
  • Enable xmlXPathOrderDocElems "which speeds up sorting of node sets."

We should benchmark these to understand why/when to enable them. Should they be on for all xpath queries, or should we let users enable them via a method parameter?

@flavorjones
Copy link
Member Author

I've got a dev branch with a WIP commit implementing these two things, and it's a significant performance boost on nokolexbor's benchmark -- a 2x speedup on top of Nick's xpath optimizations branch.

I'm going to wait for Nick's xpath optimizations to land upstream and then come back and finish this. Pretty exciting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant