Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild Location Page #414

Closed
yosevu opened this issue Oct 14, 2022 · 7 comments · Fixed by #435
Closed

Rebuild Location Page #414

yosevu opened this issue Oct 14, 2022 · 7 comments · Fixed by #435

Comments

@yosevu
Copy link
Contributor

yosevu commented Oct 14, 2022

Requirements

Requirements are open to discussion.

The Location Page has several subcomponents. The purpose of this issue is to rebuild the top level structure using placeholder elements for the sub-components listed below.

  • Create a LocationPage component.
  • Integrate the component in main.tsx and render it at the /locations/:id route.
  • Migrate review-page.ejs.
  • Create placeholder elements for subcomponents

Subcomponents

  • LocationNavigation
  • LocationHeader
  • LocationReviews
  • LocationOverview

References

Screen Shot 2022-10-15 at 3 55 31 PM

@mnosov622
Copy link

Hi @yosevu !

I'm willing to work on that. Could you please provide more details about what should be changed ?

Thank you.

@yosevu
Copy link
Contributor Author

yosevu commented Oct 15, 2022

Hi @mnosov622, I added details for this issue and assigned it to you. Let me know if you have questions!

@mnosov622
Copy link

Hi !

Thank you. I will work on that.

@mnosov622
Copy link

mnosov622 commented Oct 15, 2022

@yosevu So we can omit the reviews itself ? What should happen when we click on "1 Review" ?

@yosevu
Copy link
Contributor Author

yosevu commented Oct 15, 2022

@yosevu So we can omit the reviews itself ? What should happen when we click on "1 Review" ?

Yes, this is a very simple story just to set up the structure for the Location Page and integrate it in main.tsx. It should only include code in review-page.ejs and use placeholder elements like <div>Location Overview</div> for the subcomponents. "1 Review" is a part of the Location Overview (#420), so will be implemented there. Does that make sense?

@mnosov622
Copy link

Yes, got it.

Thank you!

@yosevu
Copy link
Contributor Author

yosevu commented Oct 16, 2022

Make sure to update your branch with main @mnosov622. I merged Rebuild Home Page #421, which you can also use as a reference for the Location Page.

@yosevu yosevu assigned yosevu and unassigned mnosov622 Oct 30, 2022
@yosevu yosevu moved this from Todo to In Progress in Sparkeats React TypeScript Rebuild Oct 30, 2022
yosevu added a commit that referenced this issue Oct 30, 2022
@yosevu yosevu linked a pull request Oct 30, 2022 that will close this issue
yosevu added a commit that referenced this issue Oct 30, 2022
yosevu added a commit that referenced this issue Oct 30, 2022
yosevu added a commit that referenced this issue Nov 4, 2022
yosevu added a commit that referenced this issue Nov 4, 2022
yosevu added a commit that referenced this issue Nov 4, 2022
yosevu added a commit that referenced this issue Nov 4, 2022
yosevu added a commit that referenced this issue Nov 5, 2022
@yosevu yosevu closed this as completed in 8f46062 Nov 5, 2022
Repository owner moved this from In Progress to Done in Sparkeats React TypeScript Rebuild Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants