Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#805 회원 탈퇴 구현 #806

Open
wants to merge 24 commits into
base: dev
Choose a base branch
from

Conversation

jinhyeonkwon
Copy link
Contributor

@jinhyeonkwon jinhyeonkwon commented Aug 12, 2024

Summary

It closes #805

탈퇴에 대응하여

  1. 탈퇴하는 기능을 만듭니다. 정산이나 송금이 완료되지 않은 방이 있는 경우, 안내가 표시되며 탈퇴가 불가능합니다.
  2. 탈퇴한 유저는 채팅창에서 알아볼 수 있도록 표시합니다. (취소선, 색 변경, 유령 프로필 사진 등)
  3. 탈퇴 사용자의 경우, 채팅창의 신고 버튼과 해당 유저를 눌렀을 때 나오는 신고 버튼이 작동하지 않도록 합니다. (신고 관련 문구 수정도 일부 했습니다)

Global한 부분은 아래와 같이 변경되었습니다.

  1. global type인 Userwithdraw라는 field가 추가되었습니다.
  2. AxiosOption type의 method"delete" 값을 가질 수 있도록 했습니다. (탈퇴를 처리하는 API가, 처음으로 delete method를 쓰게 되었습니다)
  3. LoginInfoTypewithdraw field가 추가되었습니다.
  4. ProfileImagePropswithdraw field가 추가되었습니다. 추후 호환성에 문제가 생길 것을 대비하여, optional하게 설정하고, 비워두면 Component 코드 쪽에서 false 값을 이용하도록 하였습니다.

Further Work

  • 개인정보 처리 방침 개정 후, 탈퇴 안내문을 변경하는 PR이 필요합니다.
  • 기존의 이벤트 코드를 수정하여 새로운 이벤트를 여는 경우, 회원의 탈퇴를 고려한 수정이 필요합니다.

Images or Screenshots

메뉴

image
로그인하지 않은 경우에는 아래와 같이 보입니다.
image

탈퇴 모달 (탈퇴 가능할 때)

image
image

탈퇴 모달 (탈퇴 불가능할 때)

현재 탈퇴 불가능한 경우는 아래의 한 가지 뿐입니다.
image

탈퇴한 유저에 관한 표시

image
image
image
image
image

@jinhyeonkwon jinhyeonkwon added ⚒ enhancement New feature or request 🖥 working 아직 작업 중인 상태 labels Aug 12, 2024
@jinhyeonkwon jinhyeonkwon self-assigned this Aug 12, 2024
@jinhyeonkwon jinhyeonkwon linked an issue Aug 12, 2024 that may be closed by this pull request
4 tasks
@jinhyeonkwon jinhyeonkwon marked this pull request as draft August 12, 2024 09:30
Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for taxi-dev-preview ready!

Name Link
🔨 Latest commit 8644471
🔍 Latest deploy log https://app.netlify.com/sites/taxi-dev-preview/deploys/6745cc88c70d620008ca7099
😎 Deploy Preview https://deploy-preview-806--taxi-dev-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jinhyeonkwon jinhyeonkwon marked this pull request as ready for review November 12, 2024 08:03
@ybmin

This comment was marked as resolved.

Copy link
Member

@kmc7468 kmc7468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

packages/web/src/hooks/useTaxiAPI/useAxios.tsx Outdated Show resolved Hide resolved
packages/web/src/pages/Mypage/index.tsx Outdated Show resolved Hide resolved
packages/web/src/pages/Mypage/index.tsx Outdated Show resolved Hide resolved
packages/web/src/components/User/index.tsx Outdated Show resolved Hide resolved
packages/web/src/components/User/index.tsx Outdated Show resolved Hide resolved
packages/web/src/components/User/ProfileImage.tsx Outdated Show resolved Hide resolved
packages/web/src/components/User/ProfileImage.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚒ enhancement New feature or request 🖥 working 아직 작업 중인 상태
Projects
None yet
Development

Successfully merging this pull request may close these issues.

회원 탈퇴 구현
3 participants