-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#805 회원 탈퇴 구현 #806
Open
jinhyeonkwon
wants to merge
24
commits into
dev
Choose a base branch
from
805-회원-탈퇴-관련-채팅-기능의-수정-사항
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
The head ref may contain hidden characters: "805-\uD68C\uC6D0-\uD0C8\uD1F4-\uAD00\uB828-\uCC44\uD305-\uAE30\uB2A5\uC758-\uC218\uC815-\uC0AC\uD56D"
Open
#805 회원 탈퇴 구현 #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
4 tasks
✅ Deploy Preview for taxi-dev-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…, Room/index.tsx must be carefully reviewed)
This comment was marked as resolved.
This comment was marked as resolved.
kmc7468
requested changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다!
packages/web/src/components/ModalPopup/Body/BodyAccountCancelProcess.tsx
Outdated
Show resolved
Hide resolved
packages/web/src/components/ModalPopup/ModalAccountCancelProcess.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It closes #805
탈퇴에 대응하여
Global한 부분은 아래와 같이 변경되었습니다.
User
에withdraw
라는 field가 추가되었습니다.AxiosOption
type의method
가"delete"
값을 가질 수 있도록 했습니다. (탈퇴를 처리하는 API가, 처음으로 delete method를 쓰게 되었습니다)LoginInfoType
에withdraw
field가 추가되었습니다.ProfileImageProps
에withdraw
field가 추가되었습니다. 추후 호환성에 문제가 생길 것을 대비하여, optional하게 설정하고, 비워두면 Component 코드 쪽에서 false 값을 이용하도록 하였습니다.Further Work
Images or Screenshots
메뉴
로그인하지 않은 경우에는 아래와 같이 보입니다.
탈퇴 모달 (탈퇴 가능할 때)
탈퇴 모달 (탈퇴 불가능할 때)
현재 탈퇴 불가능한 경우는 아래의 한 가지 뿐입니다.
탈퇴한 유저에 관한 표시