Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cmake version requirement to 3.19 #414

Closed
peter-d opened this issue Mar 27, 2023 · 1 comment
Closed

Bump cmake version requirement to 3.19 #414

peter-d opened this issue Mar 27, 2023 · 1 comment
Assignees
Labels
component: plato issues related to Plato (part of Helios) component: sparta Issue is related to sparta framework enhancement Enhancement or request

Comments

@peter-d
Copy link
Contributor

peter-d commented Mar 27, 2023

Currently we require cmake 3.15 in the cmake files:

cmake_minimum_required (VERSION 3.15)

But, per cmake version history, the HDF5::HDF5 target we use, only got introduced in cmake 3.19:
Kitware/CMake@a8e0a6b

Context: this is currently breaking CI against sparta master in pr 42 of the Olympia model which still uses 3.17: https://github.com/riscv-software-src/riscv-perf-model/blob/boost_fix/conda/environment.yml

@ghost ghost assigned peter-d Mar 27, 2023
@ghost ghost added enhancement Enhancement or request component: sparta Issue is related to sparta framework component: plato issues related to Plato (part of Helios) labels Mar 27, 2023
@peter-d
Copy link
Contributor Author

peter-d commented Apr 28, 2023

Closing - #416 fixed this.

@peter-d peter-d closed this as completed Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: plato issues related to Plato (part of Helios) component: sparta Issue is related to sparta framework enhancement Enhancement or request
Projects
None yet
Development

No branches or pull requests

1 participant