Boost cmake: why use Boost_NO_BOOST_CMAKE ON on macOs?

[peter-d]

(triggered by an Olympia build issue riscv-software-src/riscv-perf-model#35)

I've noticed there's a bit of a non-standard way of finding boost for Sparta fro macOs:

map/sparta/cmake/sparta-config.cmake

Line 50 in edc3b2a

set (Boost_NO_BOOST_CMAKE ON)

Which makes it need -DBoost_DIR=/opt/homebrew/Cellar/[email protected]/1.76.0_3/lib/cmake/Boost-1.76.0 on the command line to find the boost paths if they are not in a system default location.

But most other repos (like stf_lib, for example), to find boost with cmake, you define -DBOOST_ROOT=/opt/homebrew/Cellar/[email protected]/1.76.0_3

Removing that line, on my system at least, boost is still found correctly with the standard -DBOOST_ROOT=<path>, but then I am not using conda...

Is there a specific reason to keep this like that, or can the boost setup be made simpler (and more uniform)?

[ghost]

Getting boost working with MacOS/cmake a few years back was a nightmare. Brew helps a bit, but there was something non-standard with how it was installed and how cmake interacted with it. Perhaps this is now moot since we've moved way past boost 1.65. I think I took the attitude -- it ain't broke, so don't fix.

Now it's back to broke and not standard. I'm ok with removing those constraints and trying again.

[peter-d]

Thanks for the quick feedback. It's still not obvious - I am, too, worried that while this might now work for me it's not necessarily good for everyone, but I only have this system to test on...

[peter-d]

We can close this now that #397 was merged a while ago.