Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use immutable #2

Open
chriseth opened this issue Oct 19, 2020 · 2 comments
Open

Use immutable #2

chriseth opened this issue Oct 19, 2020 · 2 comments

Comments

@chriseth
Copy link

The proxy code has a comment that tells that immutable cannot be used in inline assembly. While this is true, I wonder why you did not "copy" the immutable value to a local variable first which is then accessed through inline assembly.

@spalladino
Copy link
Owner

My original intention was to write the proxy entirely in Yul, following this example. I never got around to that, so it makes sense to simplify the current implementation by just doing as you suggest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@spalladino @chriseth and others