Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

would using lurch/rooted remove the need for red-green deployment? #1

Open
thegostep opened this issue Oct 8, 2020 · 3 comments
Open

Comments

@thegostep
Copy link

https://github.com/ricmoo/lurch/tree/master/rooted

@spalladino
Copy link
Owner

Not really. Root has the same restriction as any other CREATE2-based upgrade, which is having to deploy the upgraded version in a different tx than the SELFDESTRUCT.

@thegostep
Copy link
Author

and using a factory to bundle the calls doesn't get around this restriction? I find this surprising

@spalladino
Copy link
Owner

As far as I understand, problem is that SELFDESTRUCT does not destroy the contract - it only marks it for destruction, and the destruction is carried out when the tx finishes. I ran some tests locally and it seems to be the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants