Upcoming incompatibility with dev dependencies

[bmorris3]

It looks like there may be an upcoming compatibility issue with dev versions of some WebbPSF dependencies. A recent PR to romancal adds a dependency on WebbPSF, and it's failing on (only) devdeps. It looks like this line is the offender:

webbpsf/webbpsf/gridded_library.py

Lines 344 to 345 in af28236

	meta["DET_YX{}".format(h)] = (str((loc[1], loc[0])),
	"The #{} PSF's (y,x) detector pixel position".format(h))

The loc[0] gets defined in:

loc = np.asarray(loc, dtype=float)

and casting it to a string produces, e.g., np.float64(100.0). Later when this gets parsed:

webbpsf/webbpsf/gridded_library.py

Lines 437 to 439 in af28236

	ndd.meta['grid_xypos'] = [((float(ndd.meta[key][0].split(',')[1].split(')')[0])),
	(float(ndd.meta[key][0].split(',')[0].split('(')[1])))
	for key in ndd.meta.keys() if "DET_YX" in key]

the strings have an unexpected format, which causes to_model to crash.

I'm not sure yet which of the devdeps is responsible, but here's the dev requirements file for romancal that raised this error:

git+https://github.com/asdf-format/asdf
git+https://github.com/asdf-format/asdf-transform-schemas
git+https://github.com/asdf-format/asdf-wcs-schemas
--extra-index-url https://pypi.anaconda.org/astropy/simple astropy --pre
git+https://github.com/astropy/asdf-astropy
git+https://github.com/spacetelescope/crds
git+https://github.com/spacetelescope/gwcs
numpy>=0.0.dev0
git+https://github.com/spacetelescope/[email protected]
git+https://github.com/spacetelescope/[email protected]
scipy>=0.0.dev0
git+https://github.com/spacetelescope/stpipe
git+https://github.com/spacetelescope/stcal
git+https://github.com/spacetelescope/tweakwcs

[obi-wan76]

hi @bmorris3 , we are going to take a look at it. We are currently doing the next stable release of webbpsf v1.2.0. Let me know if the problem persist in stable. If it does, then we'll investigate it further to find a solution.
Thanks!

[bmorris3]

Hi @obi-wan76, this is still an issue for devdeps tests in romancal. Do you have a timeline for v1.2.0?

[obi-wan76]

V1.2.1 is already out, is this still an issue with the latest version of webbpsf? @BradleySappington, any comments?

[BradleySappington]

Just took a quick look at the devdeps error, I'm going to assume that 1.2.1 does NOT address this issue (unless @bmorris3 disagrees).

[BradleySappington]

@bmorris3, for context, we were mid release when this issue was raised. I'm planning to spend a few days on webbpsf over the next week or two.

[BradleySappington]

@braingram - Adding you as assignee due to #743

[BradleySappington]

closing per comment in #743 that says this is fixed with that changeset