Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIRCam SW distortion center position #226

Closed
mperrin opened this issue Aug 28, 2018 · 3 comments
Closed

NIRCam SW distortion center position #226

mperrin opened this issue Aug 28, 2018 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@mperrin
Copy link
Collaborator

mperrin commented Aug 28, 2018

Issue by JarronL
Friday Jul 20, 2018 at 00:49 GMT
Originally opened as mperrin/webbpsf#226


In checking out the distortion results in v0.7.0, I noticed resulting PSFs getting shifted in ways I was not expecting. These shifts depend on values specified in detector_position attribute. For the SW modules, I would have expected any PSF shifting to be relative to the center of the entire focal plane rather than the center of a given detector.

For instance, setting detector='A1' and detector_position=(1024,1024) shows a well-centered PSF, whereas values of (0,0), (0,2047), (2047,0), and (2047,2047) all show PSFs shifted diagonally by about 0.47". However, SWA and SWB consist of four detectors with the center of the field situated at their four adjoining corners. I would have expected that center of the field to be the preferential position where the PSF is "unshifted." This appears to be a consequence of the fact that the apply_distortion function uses the detector-specific aperture (e.g., NRCA1_FULL), so it's always using the center of the detector as the relative position to determine PSF shifting.

@mperrin mperrin added this to the 0.8.0 milestone Aug 29, 2018
@mperrin mperrin added the bug Something isn't working label Sep 18, 2018
@mperrin
Copy link
Collaborator Author

mperrin commented Sep 26, 2018

@shanosborne are you comfortable that this issue has been addressed by your PR #229? If you agree let me know and we can close this issue.

@shanosborne
Copy link
Contributor

@mperrin Yes - I am comfortable that #229 will fix this issue (once the PR has been finalized- I still have that 1 mean vs median question)

@mperrin
Copy link
Collaborator Author

mperrin commented Oct 23, 2018

Fixed by #229

@mperrin mperrin closed this as completed Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants