Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding keyword dictionary "title" vs datamodel schema property "title" comparison #365

Open
braingram opened this issue Nov 19, 2024 · 0 comments

Comments

@braingram
Copy link
Collaborator

Uncal files contain fits headers formatted based on the keyword dictionary including "sections":


        Observation identifiers

DATE-OBS= '2020-06-05'         / [yyyy-mm-dd] UTC date at start of exposure

which I believe come from top file property titles like the following:

                "observation" : {
                    "title" : "Observation identifiers",

(aside: It's unclear at the moment how these relate to "Section" in the keyword definition)

"cal" files have similar sections


        Observation identifiers

DATE-OBS= '2019-10-15'         / [yyyy-mm-dd] UTC date at start of exposure

However these are derived from the datamodel schemas:

title = schema.get('title')
if title is not None:
current_comment_stack = fits_context.comment_stack
current_comment_stack.append(ensure_ascii(title))

Using the "title" keyword in the schemas:
observation:
title: Observation identifiers

If we want these to agree we would benefit from having the kwtool compare these for differences.

@braingram braingram changed the title Consider adding keyword dictionary "section" vs datamodel schema property "name" comparison Consider adding keyword dictionary "title" vs datamodel schema property "title" comparison Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant