Add folding period to ephemeris viewers axis label #62
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
- Coverage 94.93% 94.92% -0.01%
==========================================
Files 32 32
Lines 1381 1359 -22
==========================================
- Hits 1311 1290 -21
+ Misses 70 69 -1 ☔ View full report in Codecov by Sentry. |
| self.figure.axes[0].num_ticks = 5 | ||
|
|
||
| ephem = self.jdaviz_helper.plugins.get('Ephemeris', None) | ||
| if ephem: | ||
| self.figure.axes[0].label = f'phase (P = {ephem.period:.2g} d)' |
There was a problem hiding this comment.
I wonder if this rounding could be deceptive.... can we use tex to show ~=?
We could also add a settings expansion menu and make this a togglable option (having phase:ephemeris_component might also be an option people want in some cases, and actually briefly happens sometimes since that is the name of the data component). It would be really cool if we had some presets for the labels but also allowed custom formatting 😉
There was a problem hiding this comment.
Getting back to this - I think for now this is a good improvement, if we can use tex to avoid rounding confusion. Let's defer anything else to potential follow-up work 🐱.
It's easy to forget what period you have set in the Ephemeris plugin, and it's a bit annoying to need to open the plugin if it isn't already visible. This confusion is multiplied when you have multiple ephemerides (with distinct periods).
This PR adds the period to the x-axis label in phase viewers. Here's an example for RR Lyra:
The x axis is probably the best place to put the period label for now. I tried using bqplot's
titleattr, but it only sits at the top-center. See the right-most phase viewer here:Often the data will sit beneath that label, so I prefer the x label.