-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLA-998: Proper handling of files which have SCI extensions completely zero in RAW #1902
HLA-998: Proper handling of files which have SCI extensions completely zero in RAW #1902
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes need to be made to accommodate multiple chips.
The utils.py module in drizzlepac has a function, count_sci_extensions. |
…/github.com/s-goldman/drizzlepac into hla-998_science_data_of_only_zeros_10_22_24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All issues have been addressed.
Resolves HLA-998
Closes #
This PR addresses the need to skip processing for exposures with science arrays of only zeros in ALL science extensions. One or multiple science extensions with all zeros will result in warnings for each extension.
This PR does not use
no_proc_keys
orno_proc_values
, but does set do_process=False.I also amended (and now use) the
util.count_sci_ext
function to return the indices of the science extensions if thereturn_ind
flag is used.I've also changed the variable related to the error of little-to-no exposure time (
is_zero
-->exposure_time_near_zero
) in order to avoid confusion with our new error case.Checklist for maintainers
CHANGELOG.rst
within the relevant release sectionHow to run regression tests on a PR
jenkins test