Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLA-998: Proper handling of files which have SCI extensions completely zero in RAW #1902

Conversation

s-goldman
Copy link
Collaborator

@s-goldman s-goldman commented Oct 22, 2024

Resolves HLA-998

Closes #

This PR addresses the need to skip processing for exposures with science arrays of only zeros in ALL science extensions. One or multiple science extensions with all zeros will result in warnings for each extension.

This PR does not use no_proc_keys or no_proc_values, but does set do_process=False.

I also amended (and now use) the util.count_sci_ext function to return the indices of the science extensions if the return_ind flag is used.

I've also changed the variable related to the error of little-to-no exposure time (is_zero --> exposure_time_near_zero) in order to avoid confusion with our new error case.

Checklist for maintainers

  • added entry in CHANGELOG.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR

jenkins test

@s-goldman s-goldman added bug jirahub-ignore Avoid linking to Jira labels Oct 22, 2024
@s-goldman s-goldman marked this pull request as ready for review October 23, 2024 15:33
@s-goldman s-goldman requested review from mdlpstsci and a team as code owners October 23, 2024 15:33
Copy link
Collaborator

@mdlpstsci mdlpstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes need to be made to accommodate multiple chips.

@mdlpstsci
Copy link
Collaborator

The utils.py module in drizzlepac has a function, count_sci_extensions.

Copy link
Collaborator

@mdlpstsci mdlpstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All issues have been addressed.

@s-goldman s-goldman merged commit f308cc8 into spacetelescope:main Oct 29, 2024
17 of 18 checks passed
@s-goldman s-goldman deleted the hla-998_science_data_of_only_zeros_10_22_24 branch October 29, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug jirahub-ignore Avoid linking to Jira
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants