Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly fix the wcs preferential order REL > IMG, GAIA*3 > GAIA[2|1] #1645

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Correctly fix the wcs preferential order REL > IMG, GAIA*3 > GAIA[2|1] #1645

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab64039
Correctly fix the wcs preferential order REL > IMG, GAIA*3 > GAIA[2|1]
mdlpstsci Aug 15, 2023
94ce39d
Add a more thorough comment as suggested in PR review.
mdlpstsci Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions drizzlepac/runastrodriz.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,9 +186,11 @@
envvar_qa_stats_name = "PIPELINE_QUALITY_TESTING"
envvar_reset_idctab_name = "PIPELINE_RESET_IDCTAB"

# Order of preference for common WCS solutions - brute force choice of the GAIA catalog preference
wcs_preference = ['IDC_?????????-FIT_REL_GAIA*3', 'IDC_?????????-FIT_REL_GAIADR2', 'IDC_?????????-FIT_REL_GAIADR1',
'IDC_?????????-FIT_IMG_GAIA*3', 'IDC_?????????-FIT_IMG_GAIADR2', 'IDC_?????????-FIT_IMG_GAIADR1',
# Order of preference for common WCS solutions - brute force choice of the GAIA catalog preference.
# Enforce the chosen order for the WCS preferential solution for all exposures in a dataset.
# REL fit method is better than IMG, and GAIA*3 catalog is better than GAIADR2 or GAIADR1.
wcs_preference = ['IDC_?????????-FIT_REL_GAIA*3', 'IDC_?????????-FIT_IMG_GAIA*3', 'IDC_?????????-FIT_REL_GAIADR2',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be useful to add a sentence describing the order, like what you wrote in the comment:
Enforce the chosen order for the WCS preferential solution for all exposures in a dataset. REL is better than IMG, and GAIA*3 is better than GAIA 2 or GAIA1.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address in commit 94ce39d.

'IDC_?????????-FIT_IMG_GAIADR2', 'IDC_?????????-FIT_REL_GAIADR1', 'IDC_?????????-FIT_IMG_GAIADR1',
'IDC_?????????-GSC240', 'IDC_?????????']

# History:
Expand Down