Correctly fix the wcs preferential order REL > IMG, GAIA*3 > GAIA[2|1] #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1645 +/- ##
=======================================
Coverage 32.40% 32.40%
=======================================
Files 159 159
Lines 35049 35049
=======================================
Hits 11358 11358
Misses 23691 23691
☔ View full report in Codecov by Sentry. |
mdlpstsci
force-pushed
the
dedux_fix_wcs_preference
branch
from
954ffaf
to
ab64039
Compare
raswaters
reviewed
Aug 15, 2023
| @@ -187,8 +187,8 @@ | |||
| envvar_reset_idctab_name = "PIPELINE_RESET_IDCTAB" | |||
|
|
|||
| # Order of preference for common WCS solutions - brute force choice of the GAIA catalog preference | |||
| wcs_preference = ['IDC_?????????-FIT_REL_GAIA*3', 'IDC_?????????-FIT_REL_GAIADR2', 'IDC_?????????-FIT_REL_GAIADR1', | |||
| 'IDC_?????????-FIT_IMG_GAIA*3', 'IDC_?????????-FIT_IMG_GAIADR2', 'IDC_?????????-FIT_IMG_GAIADR1', | |||
| wcs_preference = ['IDC_?????????-FIT_REL_GAIA*3', 'IDC_?????????-FIT_IMG_GAIA*3', 'IDC_?????????-FIT_REL_GAIADR2', | |||
There was a problem hiding this comment.
It would be useful to add a sentence describing the order, like what you wrote in the comment:
Enforce the chosen order for the WCS preferential solution for all exposures in a dataset. REL is better than IMG, and GAIA*3 is better than GAIA 2 or GAIA1.
There was a problem hiding this comment.
Address in commit 94ce39d.
raswaters
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce the chosen order for the WCS preferential solution for all exposures in a dataset. REL is better than IMG, and GAIA*3 is better than GAIA 2 or GAIA1.