-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs to reflect changes in TICA cube format #93
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
=======================================
Coverage 94.45% 94.45%
=======================================
Files 8 8
Lines 1443 1443
=======================================
Hits 1363 1363
Misses 80 80 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Ben Falk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting a typo fix. Also, those numbers (15 mins and 45 mins) are outdated, and I think we should update them in case a user is trying to make their own cubes and find that their processing time is wildly different from what's documented: Could you update the processing time for a 64 GB machine for EM2 data? And then for that last sentence you can just put On a system with less memory [...], this time can increase significantly
.
It says there are 2 files changed in this PR but I only see the index.rst
changes, so I might have to do another review for the other file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this! Just some small typos and incomplete sentences, but no large structural changes required, this looks good.
Update docs to reflect changes in TICA cube format