Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asb 26944 numpy 2 #120

Merged
merged 4 commits into from
Jul 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/ci_workflows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@ jobs:
python: "3.10"
toxenv: py310-test-alldeps

- name: Python 3.10 with numpy 2
os: ubuntu-latest
python: "3.10"
toxenv: py310-test-alldeps-numpy2

steps:
- name: Checkout code
uses: actions/checkout@v3
Expand Down
1 change: 1 addition & 0 deletions astrocut/utils/wcs_fitting.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

# flake8: noqa

import copy
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just a missing import, unrelated to NumPy 2.

import numpy as np

from astropy import units as u
Expand Down
2 changes: 1 addition & 1 deletion docs/astrocut/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ aligned and have the same pixel scale, no checking is done by Astrocut.
>>> center_coord = SkyCoord("150.0945 2.38681", unit='deg')
>>> cutout_size = [200,300]

>>> png_files = img_cut(input_files, center_coord, cutout_size, img_format='png', drop_after="") #doctest: +SKIP
>>> png_files = img_cut(input_files, center_coord, cutout_size, img_format='png') #doctest: +SKIP
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a quick fix for a documentation issue I noticed while creating the different types of astrocut products.

>>> print(png_files[0]) #doctest: +SKIP
./hlsp_candels_hst_acs_cos-tot-sect23_f606w_v1.0_drz_150.094500_2.386810_200-x-300_astrocut.png

Expand Down
2 changes: 2 additions & 0 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,14 @@ description =
astropy52: with astropy 5.2.*
numpy120: with numpy 1.20.*
numpy123: with numpy 1.23.*
numpy2: with numpy 2
astroquery04: with astroquery 0.4.*

# The following provides some specific pinnings for key packages
deps =
numpy120: numpy==1.20.*
numpy123: numpy==1.23.*
numpy2: numpy==2.0.*

astropy52: astropy==5.2.*

Expand Down
Loading