Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asb 26944 numpy 2 #120

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Asb 26944 numpy 2 #120

merged 4 commits into from
Jul 1, 2024

Conversation

snbianco
Copy link
Collaborator

@snbianco snbianco commented Jun 21, 2024

Adds another testing environment that uses NumPy 2.0.0.

@@ -15,6 +15,7 @@

# flake8: noqa

import copy
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just a missing import, unrelated to NumPy 2.

@@ -127,7 +127,7 @@ aligned and have the same pixel scale, no checking is done by Astrocut.
>>> center_coord = SkyCoord("150.0945 2.38681", unit='deg')
>>> cutout_size = [200,300]

>>> png_files = img_cut(input_files, center_coord, cutout_size, img_format='png', drop_after="") #doctest: +SKIP
>>> png_files = img_cut(input_files, center_coord, cutout_size, img_format='png') #doctest: +SKIP
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a quick fix for a documentation issue I noticed while creating the different types of astrocut products.

@snbianco snbianco marked this pull request as ready for review June 27, 2024 13:10
@snbianco snbianco requested a review from havok2063 June 27, 2024 13:11
@snbianco snbianco self-assigned this Jun 27, 2024
Copy link
Contributor

@havok2063 havok2063 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@snbianco snbianco merged commit f47fc89 into main Jul 1, 2024
8 checks passed
@snbianco snbianco deleted the ASB-26944-numpy-2 branch July 1, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants