Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gem :dry-configurable dependecy updated to 1.2.0 #69

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

gem :dry-configurable dependecy updated to 1.2.0 #69

wants to merge 2 commits into from

Conversation

artk0de
Copy link

@artk0de artk0de commented Oct 22, 2024

Updates dry-configuration gem depency to 1.2.0 version. My purpose is using fresh telegram-bot-ruby together with tdlib-ruby

artk0de
artk0de commented Oct 22, 2024
View reviewed changes
lib/tdlib-ruby.rb
@@ -16,19 +16,19 @@ def root_path
setting :encryption_key

setting :client do
setting :api_id, &:to_i
setting :api_id, default: 0
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default: 0

is it okay? Anyway it is necessary attribute and should be overwritten.

Or is it better to drop default value maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@artk0de