Using service name 'default' results in stop/disable/enable/start actions on every run

[piloos]

👻 Brief Description

When using mysql_service 'default' do ... action [:create, :start] ... end, the service mysql is stopped, disabled, enabled and started on every run even if no configuration changes are required.

🥞 Cookbook version

8.6.0

👩‍🍳 Chef-Infra Version

15.6.10

🎩 Platform details

Ubuntu 16.04

Steps To Reproduce

Steps to reproduce the behavior:

1. Create a recipe with a mysql_service 'default' do ... end

🚓 Expected behavior

On subsequent Chef runs, I expect nothing to happen to the state of the mysql service.

➕ Additional context

Issue is probably caused by the fact that default will result in the service name mysql. The resource first tries to disable the system service, which is also called mysql and then enables his own service which is again called myqsl.
This statement is confirmed by the fact that selecting another service name does not cause the faulty behavior.

[p8]

Hmm, I had the same issue but didn't think it had anything to do with default service name.
stop_system_service should probably not be called when the service name is default.

mysql/libraries/mysql_service_manager_systemd.rb

Lines 120 to 130 in d53a05f

	action_class do
	def stop_system_service
	# service management resource
	service 'mysql' do
	service_name system_service_name
	provider Chef::Provider::Service::Systemd
	supports status: true
	action [:stop, :disable]
	end
	end

[paul-krohn]

I can confirm I see this same behavior on: Chef 16.1.16-1, Ubuntu 18.04.3 LTS, cookbook version 8.7.2.

[axl89]

I can also confirm this issue on Ubuntu 18.04.5 LTS and cookbook version 10.1.1.