Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing generics for new version of zip module #309

Closed
ctb opened this issue Apr 22, 2024 · 1 comment
Closed

missing generics for new version of zip module #309

ctb opened this issue Apr 22, 2024 · 1 comment

Comments

@ctb
Copy link
Collaborator

ctb commented Apr 22, 2024

#308 fails build with:

    Compiling sourmash_plugin_branchwater v0.9.3 (/home/runner/work/sourmash_plugin_branchwater/sourmash_plugin_branchwater)
error[E0107]: missing generics for struct `FileOptions`
Error:     --> src/utils.rs:1125:30
     |
1125 |     zip_options: zip::write::FileOptions,
     |                              ^^^^^^^^^^^ expected 1 generic argument
     |
note: struct defined here, with 1 generic parameter: `T`
    --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/zip-1.1.1/src/write.rs:193:12
     |
193  | pub struct FileOptions<T: FileOptionExtension> {
     |            ^^^^^^^^^^^ -
help: add missing generic argument
     |
1125 |     zip_options: zip::write::FileOptions<T>,
     |                                         +++


error: aborting due to 1 previous error
Error: aborting due to 1 previous error
@ctb
Copy link
Collaborator Author

ctb commented Jul 12, 2024

@bluegenes is this now fixed with #385? I expect so, closing.

@ctb ctb closed this as completed Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant