Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@sourceloop/core: CreatedOn and ModifiedOn columns should not be data driven #2158

Closed
yeshamavani opened this issue Aug 30, 2024 · 0 comments · Fixed by #2159 · May be fixed by #2188
Closed

@sourceloop/core: CreatedOn and ModifiedOn columns should not be data driven #2158

yeshamavani opened this issue Aug 30, 2024 · 0 comments · Fixed by #2159 · May be fixed by #2188

Comments

@yeshamavani
Copy link
Contributor

Describe the bug
CreatedOn and ModifiedOn columns should not be data driven
These values should always be a the current date and user should never be able to change its value based on input.

To Reproduce
Steps to reproduce the behavior:

  1. Hit any post API where the base model entity is UserModifiableEntity
  2. Pass the createdOn and modifiedOn date values as some backdated data
  3. Observe the entry in database
  4. Instead of current date the values will be one provided in input

Expected behavior
Should always be the current date time.
yeshamavani added a commit that referenced this issue Aug 30, 2024
@yeshamavani
fix(core): createdon modifiedon can not be changed via input
38908d0 
gh-2158
@yeshamavani yeshamavani mentioned this issue Aug 30, 2024
Merged
10 tasks
yeshamavani added a commit that referenced this issue Aug 30, 2024
@yeshamavani
fix(core): createdon modifiedon can not be changed via input
338eb3e 
gh-2158
yeshamavani added a commit that referenced this issue Aug 30, 2024
@yeshamavani
fix(core): can not change createdon and modifiedon
fb487df 
gh-2158
yeshamavani added a commit that referenced this issue Sep 24, 2024
@yeshamavani
fix(core): createdon modifiedon can not be changed via input (#2159)
411dd76 
* fix(core): createdon modifiedon can not be changed via input

gh-2158

* fix(core): createdon modifiedon can not be changed via input

gh-2158

* fix(core): can not change createdon and modifiedon

gh-2158
yeshamavani added a commit that referenced this issue Oct 22, 2024
@yeshamavani
fix(core): revert the changes of 2158
ee0ef46 
gh-2158
@yeshamavani yeshamavani mentioned this issue Oct 22, 2024
Merged
10 tasks
yeshamavani added a commit that referenced this issue Oct 22, 2024
@yeshamavani
fix(core): revert the changes of 2158 (#2181)
1307aa0 
gh-2158
yeshamavani added a commit that referenced this issue Oct 25, 2024
@yeshamavani
feat(core): restrict modification of createdon and modifiedon
397baec 
gh-2158
@yeshamavani yeshamavani mentioned this issue Oct 25, 2024
Open
10 tasks
yeshamavani added a commit that referenced this issue Oct 28, 2024
@yeshamavani
feat(core): lint fixes
0efe67c 
gh-2158
yeshamavani added a commit that referenced this issue Oct 28, 2024
@yeshamavani
docs(core): update the readme file
48af493 
gh-2158
yeshamavani added a commit that referenced this issue Oct 28, 2024
@yeshamavani
Merge branch 'master' into GH-2158-modify
c93bf79
yeshamavani added a commit that referenced this issue Oct 28, 2024
@yeshamavani
feat(core): restrict modification of createdon and modifiedon
9845d70 
gh-2158
yeshamavani added a commit that referenced this issue Oct 28, 2024
@yeshamavani
chore(core): lint issues
091897b 
gh-2158
yeshamavani added a commit that referenced this issue Nov 11, 2024
@yeshamavani
Merge branch 'master' into GH-2158-modify
248d670
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@yeshamavani