You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To split the image into two images (dev and prod) would be beneficial to the size of a production level image. Together with the proposed changes from #60 the prod version of this image would have less than 150MB.
The split would include a multistage dockerfile, where things like nodejs, npm, composer, yarn, etc would only be installed in the dev stage, which can later be used for development and as intermediary stage to build dependencies for the production image.
Other possibility would be to determine the image type by tag:
development: sourceboat/laravel:<version>-dev
production: sourceboat/laravel:<version>(-prod)
Pro: The image would not be split into two docker repositories
Con: The tag naming could be ambiguous
The naming of the development image would be rather unfortunate in my opinion as the -dev suffix could be interpreted such that it is the pre-realease image for that version. The term builder would not be as fitting, as that one would not only be intended for building the assets, but also for active development.
To split the image into two images (dev and prod) would be beneficial to the size of a production level image. Together with the proposed changes from #60 the prod version of this image would have less than 150MB.
The split would include a multistage dockerfile, where things like nodejs, npm, composer, yarn, etc would only be installed in the dev stage, which can later be used for development and as intermediary stage to build dependencies for the production image.
As names I propose:
docker-laravel-dev
and/ordocker-laravel-development
docker-laravel-prod
and/ordocker-laravel-production
The text was updated successfully, but these errors were encountered: