Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Started to make a pass over Chapter 5 #279

Merged
merged 24 commits into from
Jul 3, 2020
Merged

Started to make a pass over Chapter 5 #279

merged 24 commits into from
Jul 3, 2020

Conversation

TobiasWrigstad
Copy link
Collaborator

Pushing WIP here so that interested parties can follow along

@TobiasWrigstad TobiasWrigstad marked this pull request as draft June 29, 2020 23:31
@TobiasWrigstad
Copy link
Collaborator Author

I have now updated the code in §5.4 (§5.3 skipped for now).

I have based the working program on source-academy/source-programs#39 and made some very minor changes to get closer to the original.

There is a hack and some minor deviations in the code that needs addressing.

@TobiasWrigstad
Copy link
Collaborator Author

I am getting some XML linting errors e.g. when inside a <JAVASCRIPT_RUN> tag I use a < operator... Is there a way around this?

@martin-henz
Copy link
Member

I am getting some XML linting errors e.g. when inside a <JAVASCRIPT_RUN> tag I use a < operator... Is there a way around this?

Yes, < and > need to be represented in XML as < and >. XML parsers seem to differ in how strictly they enforce this.

@martin-henz
Copy link
Member

I am getting some XML linting errors e.g. when inside a <JAVASCRIPT_RUN> tag I use a < operator... Is there a way around this?

Yes, < and > need to be represented in XML as < and >. XML parsers seem to differ in how strictly they enforce this.

Also && needs to be &&. (there are some of those in 5.5.)

@TobiasWrigstad TobiasWrigstad merged commit 23a0787 into master Jul 3, 2020
@RichDom2185 RichDom2185 deleted the Chapter5 branch July 7, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants