Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all where operators to the query (==, !=, >, >=, <, <=) #154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jrmd
Copy link

@jrmd jrmd commented Sep 4, 2019

This is very similar to #116 however this doesn't make use of eval which is a security issue.

@dmurvihill
Copy link

Thanks for the contribution! This repo is no longer usable. Can you re-open here?

Also, can you fix the broken unit test and add coverage for the new operators? We're shooting for a release soon after December 1 so if you have time to submit a PR before next Thursday that will give us the best chance of including this change.

@jrmd
Copy link
Author

jrmd commented Nov 19, 2019

@dmurvihill I will certainly try find the time! currently i have my own forked version published but it would be good to get a common fork

@dmurvihill
Copy link

Cheers. We're also looking for co-maintainers.

@alexpchin
Copy link

@dmurvihill was this PR opened on https://github.com/dmurvihill/firebase-mock ? I can't see that it was?

@dmurvihill
Copy link

Hi @alexpchin, thanks for asking! This pull request lacks test coverage and as a result it incorrectly handles comparisons between types (see How query data is ordered). I've added a branch dmurvihill:feature/add-all-where-operators that merges with master and adds stub unit tests; if you can carry it the rest of the way and open a PR to my fork I would be grateful.

@dmurvihill
Copy link

Try the priorityComparator function in utils.js; I think it's close to correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants