Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add toJSON function to MockFirebaseUser #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add toJSON function to MockFirebaseUser #122

wants to merge 1 commit into from

Conversation

joshAg
Copy link

@joshAg joshAg commented Dec 5, 2018

fixes issue #121 by adding the function. I hacked together something for metadata and provider info, but it should at least not explode.

@dmurvihill dmurvihill mentioned this pull request Nov 20, 2019
Merged
@dmurvihill
Copy link

Hi @joshAg, thanks for the contribution. This repo is no longer used (see #160) but I have opened a new PR on my fork, which will be used to publish a release in early December.

For starters, can you add test coverage for the new function? Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshAg @dmurvihill