Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Access-Control configurable instead of hardcoded #5

Open
albe opened this issue Oct 7, 2020 · 1 comment
Open

Make Access-Control configurable instead of hardcoded #5

albe opened this issue Oct 7, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@albe
Copy link
Collaborator

albe commented Oct 7, 2020

Currently, the Acces-Control-Allow header is hardcoded to a * return value, i.e. the API can be called from any website. While this is a sane default, it might not be wanted in every case. The header value sent should be configurable via setting (assuming a global value for all controllers).

@albe albe added the enhancement New feature or request label Oct 8, 2020
@rr-appadaptive
Copy link

I think that even if no other services have to be handled in an application-stack, the Access-Control-Allow headers should be handled by a reverse-proxy (We us traefik - https://traefik.io - ) for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants