New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should Cargo.lock be committed? #31

Open

jonfk opened this issue Dec 23, 2019 · 1 comment

jonfk commented Dec 23, 2019

According to the cargo docs, libraries shouldn't commit their Cargo.lock file and it should actually be added to their .gitignore. https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries

I was wondering if that is correct or if there is a reason why the Cargo.lock file is committed in this repository. https://github.com/sorccu/r2d2-redis/blob/c04b8ec/Cargo.lock

jasongoodwin commented Sep 1, 2021

The lock file is committed for statically built binaries so I don't think it should be committed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment