Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] #514: Component Story Format 3.0 #520

Open
wants to merge 47 commits into
base: fresh-breath
Choose a base branch
from
Open

[refactor] #514: Component Story Format 3.0 #520

wants to merge 47 commits into from

Conversation

0x009922
Copy link
Contributor

@0x009922 0x009922 commented Mar 14, 2023 •
edited
Loading

While rewriting stories, I also generally reviewed the APIs provided by the library. In some cases I found bugs (STabsPanel); I changed internal to improve a11y in SSwitch; in some cases I found that the API might be improved (SSelect).

Useful links:

@0x009922 0x009922 linked an issue Mar 14, 2023 that may be closed by this pull request
Refactor stories to CSF 3.0 #514
Open
@0x009922 0x009922 self-assigned this Mar 14, 2023
@0x009922 0x009922 added the next Related to next lib iteration, i.e. based on Vue 3 label Mar 14, 2023
0x009922 added 19 commits March 20, 2023 10:21
@0x009922
[refactor] stories: rewrite Pagination
5c63d10
@0x009922
[chore]: fix root-level SB dev script
c07984a
@0x009922
[refactor] stories: rewrite ProgressBar
21c76a6
@0x009922
[refactor] stories: adopt Table
e116234
@0x009922
[refactor]: rewrite Tabs stories; fix components
09ca996
@0x009922
[refactor]: rewrite Switch stories and update the component
28e136f
@0x009922
[refactor] stories: rewrite notifications
8ccb490
@0x009922
[refactor] stories: rewrite Spinner
84605c0
@0x009922
[refactor] stories: rewrite Link
3fde037
@0x009922
[refactor] stories: rewrite RadioGroup
5f2645f
@0x009922
[refactor] stories: rewrite DatePicker
b71d960
@0x009922
[refactor] stories: rewrite NavigationMenu
1975b2c
@0x009922
[chore]: format
29d4898
@0x009922
[refactor] stories: rewrite Tooltip
6f8342e
@0x009922
[refactor] stories: rewrite Select, review API
4417e4c
@0x009922
[test] SSwitch: update component tests
8aefd9e
@0x009922
Merge branch '512-stricter-type-script' into 514-csf-3
d4aa6c3
@0x009922
[chore]: format
8346bda
@0x009922
[refactor] stories: rewrite Accordion
3f5e8c6
Base automatically changed from 512-stricter-type-script to fresh-breath March 21, 2023 09:44
@0x009922 0x009922 marked this pull request as ready for review March 21, 2023 10:03
@0x009922 0x009922 mentioned this pull request Mar 27, 2023
Open
4 tasks
0x009922 added 13 commits March 28, 2023 17:59
@0x009922
Merge pull request #529 from soramitsu/513-enable-eslint-rules
c658d6c 
[refactor] #513: enable ESLint a11y rules back
@0x009922
Merge pull request #530 from soramitsu/use-vue-kakuyaku
c47b27b 
[chore]: use `useParamScope` from `@vue-kakuyaku/core`
@0x009922
[chore]: update build deps
adb8d38
@0x009922
[refactor]: rm @vue/compiler-core, use vue/compiler-sfc
1209e99
@0x009922
[fix]: pnpm i --fix-lockfile
8c5726b
@0x009922
[build]: use specifically [email protected]
5e9fdfd
@0x009922
Merge remote-tracking branch 'origin/fresh-breath' into 514-csf-3
c0e1928
@0x009922
Merge branch 'fresh-breath' into 514-csf-3
423e5c0
@0x009922
Merge branch 'fresh-breath' into 514-csf-3
9a66c6e
@0x009922
[chore]: update core dev deps, use released Storybook
e3194d7
@0x009922
Merge remote-tracking branch 'origin/514-csf-3' into 514-csf-3
81276e8
@0x009922
[refactor]: use TS for storybook configs
d51d63c
@0x009922
[revert]: use [email protected]
ea95d06
@Ctepan Ctepan mentioned this pull request Jun 26, 2023
Closed
@Ctepan Ctepan mentioned this pull request Jul 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ctepan Ctepan Ctepan approved these changes

@timofeytrepalin timofeytrepalin Awaiting requested review from timofeytrepalin

@RustemYuzlibaev RustemYuzlibaev Awaiting requested review from RustemYuzlibaev

Assignees

@0x009922 0x009922

Labels
next Related to next lib iteration, i.e. based on Vue 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor stories to CSF 3.0
2 participants
@0x009922 @Ctepan