From b0f654c9d564787c439f9a2ab26063c8b379f538 Mon Sep 17 00:00:00 2001 From: Dmitry Balashov Date: Mon, 27 Mar 2023 16:22:25 +0600 Subject: [PATCH] [fix]: ignore a11y rule, add comment; link issues for the future Linked issues: - #526 - #527 - #528 --- .eslintrc.js | 44 ++++++++++++++----- packages/ui/src/components/Modal/SModal.vue | 5 ++- .../src/components/TextField/STextField.vue | 5 ++- 3 files changed, 40 insertions(+), 14 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 21825d41..5fbdeed8 100755 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -24,16 +24,13 @@ module.exports = { '@typescript-eslint/consistent-type-definitions': 'off', - // FIXME - 'vuejs-accessibility/no-static-element-interactions': 'off', - - "vuejs-accessibility/label-has-for": [ - "error", + 'vuejs-accessibility/label-has-for': [ + 'error', { // all labels should have `for` attr - "required": "id", - } - ] + required: 'id', + }, + ], }, overrides: [ { @@ -55,7 +52,7 @@ module.exports = { 'vue/one-component-per-file': 'off', // We don't need such strictness in stories - 'vue/require-prop-types': 'off' + 'vue/require-prop-types': 'off', }, }, { @@ -65,15 +62,40 @@ module.exports = { // We don't need such strictness in tests 'vue/require-default-prop': 'off', - 'vue/require-prop-types': 'off' + 'vue/require-prop-types': 'off', }, }, - // FIXME https://github.com/soramitsu/soramitsu-js-ui-library/issues/525 { files: ['**/ui/src/components/Select/**/*.vue'], rules: { + // FIXME https://github.com/soramitsu/soramitsu-js-ui-library/issues/525 'vuejs-accessibility/click-events-have-key-events': 'off', + 'vuejs-accessibility/no-static-element-interactions': 'off', + }, + }, + + { + files: ['**/ui/src/components/DatePicker/**/*.vue'], + rules: { + // FIXME https://github.com/soramitsu/soramitsu-js-ui-library/issues/526 + 'vuejs-accessibility/no-static-element-interactions': 'off', + }, + }, + + { + files: ['**/ui/src/components/Table/**/*.vue'], + rules: { + // FIXME https://github.com/soramitsu/soramitsu-js-ui-library/issues/527 + 'vuejs-accessibility/no-static-element-interactions': 'off', + }, + }, + + // FIXME https://github.com/soramitsu/soramitsu-js-ui-library/issues/528 + { + files: ['**/ui/src/components/JsonInput/**/*.vue'], + rules: { + 'vuejs-accessibility/no-static-element-interactions': 'off', }, }, ], diff --git a/packages/ui/src/components/Modal/SModal.vue b/packages/ui/src/components/Modal/SModal.vue index fcfd4907..123fbe92 100644 --- a/packages/ui/src/components/Modal/SModal.vue +++ b/packages/ui/src/components/Modal/SModal.vue @@ -254,7 +254,10 @@ useCloseOnEsc( v-bind="overlayTransitionAttrs" v-on="overlayTransitionListeners" > - + +
- - + +