Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SP2] 블로그 탭 게시물 목록 구현 #232

Merged
merged 13 commits into from
Oct 23, 2023
Merged

[SP2] 블로그 탭 게시물 목록 구현 #232

merged 13 commits into from
Oct 23, 2023

Conversation

solar3070
Copy link
Member

@solar3070 solar3070 commented Oct 22, 2023 •
edited
Loading

Summary

Screenshot

데스크탑 & 태블릿 모바일
스크린샷 2023-10-22 오후 4 54 21 스크린샷 2023-10-22 오후 4 54 10

Comment

  • 스레드에서 아티클 및 활동 후기 API 응답에 대해 논의하였습니다.
  • 아티클 API 응답 
     id: number;
 part: string;
 generation: number;
 thumbnailUrl: string;
 title: string;
 description: string;
 author: string;
 authorProfileImageUrl: string | null;
 url: string;
 uploadedAt: string;
 likeCount: number;
 liked: boolean;
  • 활동 후기 API 응답 
     id: number;
 part: string;
 generation: number;
 thumbnailUrl: string;
 title: string;
 description: string;
 author: string;
 authorProfileImageUrl: string | null;
 url: string;
 uploadedAt: string;
 subject: string;
  • 활동 후기 API 응답에서 많은 변경이 있습니다. API 관련 작업은 화요일(10월 24일) 저녁까지 작업해주신다고 합니다.
  • 스토리북의 필요성을 느끼고 있습니다..

@solar3070 solar3070 self-assigned this Oct 22, 2023
SeojinSeojin
SeojinSeojin reviewed Oct 22, 2023
View reviewed changes
src/views/BlogPage/components/BlogPostList/index.tsx
@@ -0,0 +1,20 @@
import type { BlogPostListType } from '@src/lib/types/blog';
import BlogPost from '@src/views/BlogPage/components/BlogPost';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요기 index.ts도 있고 index.tsx도 있어서 default export가 없다는 CI 에러가 발생하고 있어요..!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BlogPost 폴더 속 컴포넌트들은 BlogPost/index.tsx 에서만 쓰이는 거라면 default export가 없어도 괜찮지 않을까요..?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 > 넵 지금 밖이라서 집 가서 고치도록 하겠습니다..!
2 > import문이 여러줄 되는 게 싫어서 index를 만들었는데 없애는 게 더 좋을까요..?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그런 이유에서 index.ts를 만들었군요!
일단 CI에서 에러가 뜨고 있으니 BlogPost/index.tsx에서는 컴포넌트를 각 import하는 것으로 바꿔야할 것 같아요..!

여러줄 import가 싫다면 파일명을 다르게 하는 방법은 안될까요? 그리고 이 파일명도 컨벤션으로 정하고요!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index.ts는 제거하고 각각 import하는 걸로 바꿨습니다!
사실 지금은 import문이 두 줄이어서 해당 파일이 필수라고 느껴지지는 않아요. 그래서 일단은 각각 import하는 방식으로 가고 나중에 import문이 너무 많아지거나 다른 분들도 필요성을 느낄 때 다시 한 번 논의해봐도 좋을 것 같습니다!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 좋아요~!!

f0rever0
f0rever0 approved these changes Oct 22, 2023
View reviewed changes
src/views/BlogPage/components/BlogPost/index.tsx Outdated
blogPost: BlogPostType;
}

function BlogPost({ selectedTap, blogPost }: BlogPostProps) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion;

저희 컨벤션에 export default function~ 으로 작업하기로 되어있습니다!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 꼼꼼하게 봐주셔서 감사합니다!!

src/views/BlogPage/components/BlogPostList/index.tsx
@@ -0,0 +1,20 @@
import type { BlogPostListType } from '@src/lib/types/blog';
import BlogPost from '@src/views/BlogPage/components/BlogPost';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그런 이유에서 index.ts를 만들었군요!
일단 CI에서 에러가 뜨고 있으니 BlogPost/index.tsx에서는 컴포넌트를 각 import하는 것으로 바꿔야할 것 같아요..!

여러줄 import가 싫다면 파일명을 다르게 하는 방법은 안될까요? 그리고 이 파일명도 컨벤션으로 정하고요!

@solar3070 solar3070 merged commit f03f688 into develop Oct 23, 2023
1 check passed
@solar3070 solar3070 deleted the feat/#221-blog-tab-post branch October 23, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f0rever0 f0rever0 f0rever0 approved these changes

@SeojinSeojin SeojinSeojin SeojinSeojin left review comments

Assignees

@solar3070 solar3070

Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

블로그 탭 게시물 목록 구현
3 participants
@solar3070 @SeojinSeojin @f0rever0