Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SP2] @sopt-makers/colors 적용 #231

Merged
merged 3 commits into from
Oct 22, 2023

Conversation

solar3070
Copy link
Member

@solar3070 solar3070 commented Oct 22, 2023

Summary

Screenshot

image

Comment

  • 기존 컬러 상수를 제거하고 makers-frontend의 컬러 시스템을 사용합니다.
  • import { colors } from '@src/lib/styles/colors'; -> import { colors } from '@sopt-makers/colors';
  • 기존 gray900이 gray950으로 네이밍 변경이 되었고 새로운 컬러인 gray900이 생겼습니다! 기존에 gray900을 사용하는 곳이 있었다면 gray950으로 바꿔주세요!

  • 누락된 컬러가 있는 것 같아서 업데이트 문의 드렸습니다. 반영 후 머지하겠습니다! (white 및 alpha) - 업데이트 완료

@solar3070 solar3070 self-assigned this Oct 22, 2023
Copy link
Contributor

@f0rever0 f0rever0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 좋습니다!

@solar3070 solar3070 merged commit ef8bb91 into develop Oct 22, 2023
1 check passed
@solar3070 solar3070 deleted the feat/#230-makers-frontend-library branch October 22, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@sopt-makers/colors 적용
2 participants