-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SP2] blog tab navigation #228
Changes from 15 commits
7145e8a
8bbcfe5
94a89ee
12efe7d
78c2717
80adbca
c10ea97
9c116aa
d9ea44c
88ae4c1
4c2e5f6
babab4f
85aa5ef
5c178a1
8966d63
7dc7385
43776ca
8f2e09a
dc3d174
51d8a5e
190d379
c02989e
2064b1e
51d8f9a
d0557d7
5c31a0d
bb6d10a
6058f69
59cc555
7f2037a
74553a9
3f1bfb4
afe94b6
dc96bc5
5423574
1ed8aaf
173801f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,19 +8,20 @@ | |
justify-content: center; | ||
align-items: center; | ||
position: fixed; | ||
background-color: rgba(22, 22, 28, 0.9); | ||
background-color: #0f0f12; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 여기도요!!! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. scss 파일에서 color 코드를 불러오려는데 ./src/components/Header/header.module.scss
SassError: Can't find stylesheet to import.
╷
2 │ @import '@src/lib/styles/colors.ts';
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^
╵
src/components/Header/header.module.scss 2:9 root stylesheet 이러한 에러가 계속 떠서 아예 styled-component를 통일하게 사용하도록 |
||
backdrop-filter: blur(20px); | ||
z-index: 100; | ||
padding: 0 20px; | ||
top: 0; | ||
|
||
@include tablet { | ||
height: 48px; | ||
padding: 0 48px; | ||
} | ||
|
||
@include mobile { | ||
height: 48px; | ||
min-height: 48px; | ||
padding: 0 20px; | ||
|
||
justify-content: space-between; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,20 +12,9 @@ export const menuTapList: MenuTapList = [ | |
href: '/project', | ||
}, | ||
{ | ||
type: MenuTapType.Parent, | ||
type: MenuTapType.Router, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 좋네용.. 사실 이제 MenuTapType.Anchor 도 사라지긴 해서 type 이라는 친구도 없어도 되긴 혀요 다른 것이 추가될 수도 있으니 살려두어도 괜찮을 것 같습니당 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. MenuTapType.Anchor 도 지울까 했는데,,, 일단 살려뒀습니다! |
||
title: '블로그', | ||
children: [ | ||
{ | ||
type: MenuTapType.Router, | ||
title: '활동후기', | ||
href: '/review', | ||
}, | ||
{ | ||
type: MenuTapType.Router, | ||
title: '솝티클', | ||
href: '/sopticle', | ||
}, | ||
], | ||
href: '/blog', | ||
}, | ||
{ | ||
type: MenuTapType.Router, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,17 +8,17 @@ export const colors = { | |
white: '#FFFFFF', | ||
black: '#000000', | ||
|
||
gray10: '#F0F0F0', | ||
gray30: '#E4E4E5', | ||
gray50: '#C3C3C6', | ||
gray100: '#9D9DA4', | ||
gray200: '#808087', | ||
gray300: '#66666D', | ||
gray400: '#515159', | ||
gray500: '#3F3F47', | ||
gray600: '#2E2E35', | ||
gray700: '#202025', | ||
gray800: '#17171C', | ||
gray10: '#FCFCFC', | ||
gray30: '#F0F0F0', | ||
gray50: '#E4E4E5', | ||
gray100: '#C3C3C6', | ||
gray200: '#9D9DA4', | ||
gray300: '#808087', | ||
gray400: '#66666D', | ||
gray500: '#515159', | ||
gray600: '#3F3F47', | ||
gray700: '#2E2E35', | ||
gray800: '#202025', | ||
gray900: '#0F0F12', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 최신 브랜치를 머지해주쎄용~!! |
||
|
||
blue50: '#C8E1FF', | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export { default } from '@src/views/BlogPage'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. /blog 로 접속하면 해당 페이지입니다! |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
import PageLayout from '@src/components/common/PageLayout'; | ||
import Navigation from './components/navigation'; | ||
|
||
export default function BlogPage() { | ||
return ( | ||
<PageLayout> | ||
<Navigation /> | ||
</PageLayout> | ||
); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion; 해당 코드를 [제안 이유]
@SeojinSeojin @f0rever0 다들 어떻게 생각하시나요? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 사실 저도 이번에 og 버그를 잡으면서 SSR을 위해서 re-export를 하던 구조를 깨버렸기 때문에... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요것 이제 새 컬러 상수를 사용해 주셔요..!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요 컬러는 mds에 없어서...! 색상코드를 넣었습니다! pd에게 다시 확인하고 커밋해둘게요!