[SP2] 드롭다운 컴포넌트 추가, 프로젝트 페이지 필터에 적용 #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI가 돌지 않은 이유는 .. 제가 레거시 필터코드를 제거하지 않았기 때문입니다 ㅜㅜ |
f0rever0
approved these changes
Oct 19, 2023
|
|
||
| return ( | ||
| <div> | ||
| <St.SelectTrigger |
There was a problem hiding this comment.
suggestion;
저희 컨벤션에 style 을 S.${스타일네임}로 하기로 했어요!
There was a problem hiding this comment.
S였군요 .. 후딱 고치겠습니다!! 정말 고마워요!!!!
| @@ -34,3 +34,5 @@ type TabTypeOption<T> = { | |||
|
|
|||
| export type TabType = TabTypeOption<Part>; | |||
| export type ExtraTabType = TabTypeOption<ExtraPart>; | |||
|
|
|||
| export type LabelKeyType = string | number | symbol; | |||
There was a problem hiding this comment.
question;
key 값의 타입으로 symbol이 오는 경우는 어떤게 있을까요?
There was a problem hiding this comment.
Record에서 key 자리에 올 수 있는 타입이 string, number, symbol이라서 일단 이렇게 적어두었어요 ..!
저희는 enum값으로 string이나 number만 쓰게 될 것 같긴 합니다!
Comment on lines
+33
to
+34
| const selectItemWrapperRef = useRef<HTMLDivElement>(null); | ||
| const selectTriggerRef = useRef<HTMLButtonElement>(null); |
There was a problem hiding this comment.
question;
Item과 Trigger 을 각각 div, button 분리해 다른 ref를 사용한 이유가 있나요?
둘 다 같은 ref를 참조해도 되는거 아닌가 싶어서요!
There was a problem hiding this comment.
같은 ref를 참조하면 더 밑에 있는 ref가 위에 있는 ref를 덮어쓰게 되지 않나요 ..??!
같은 ref를 참조하는 상황에 대하여 더 자세히 설명 주시면 감사하겠습니닷..!
f0rever0
approved these changes
Oct 20, 2023
올릴게요!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Screenshot
2023-10-19.7.54.37.mov
Comment