Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SP2] 리쿠르팅 알림 신청 입력란에 이메일 pattern 추가 #215

Merged
merged 1 commit into from
Oct 16, 2023
Merged

[SP2] 리쿠르팅 알림 신청 입력란에 이메일 pattern 추가 #215

merged 1 commit into from
Oct 16, 2023

Conversation

f0rever0
Copy link
Contributor

Summary

image
기존에 사진과 같이 이메일 형식에 맞지 않은 값이 저장이 되어서 pattern 을 추가해 이를 해결했습니다!

Screenshot

스크린샷 2023-10-13 오후 10 19 31 다음과 같이 input 자체에 경고 메시지가 뜹니다!

Comment

@f0rever0 f0rever0 self-assigned this Oct 13, 2023
SeojinSeojin
SeojinSeojin approved these changes Oct 14, 2023
View reviewed changes
Copy link
Member

@SeojinSeojin SeojinSeojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넘 훌륭합니다~!!

(나중에) regex 패턴들도 상수로 모두 빼도 좋을 것 같네요 ..!!
(저희 UI 중 다른 곳에서 쓰일 것 같진 않지만 테스트코드 같은걸 만들 때 좋을 것 같아서요!!)

@f0rever0 f0rever0 merged commit d1c4681 into develop Oct 16, 2023
1 check passed
@f0rever0 f0rever0 deleted the feat/#214_email_pattern branch October 16, 2023 04:47
@f0rever0 f0rever0 changed the title [SP1] 리쿠르팅 알림 신청 입력란에 이메일 pattern 추가 [SP2] 리쿠르팅 알림 신청 입력란에 이메일 pattern 추가 Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solar3070 solar3070 solar3070 approved these changes

@SeojinSeojin SeojinSeojin SeojinSeojin approved these changes

Assignees

@f0rever0 f0rever0

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@f0rever0 @SeojinSeojin @solar3070